From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BBAB36B03 for ; Mon, 9 Oct 2023 15:21:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RVa363cz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E6D2C433C8; Mon, 9 Oct 2023 15:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696864892; bh=5Zn+SnAc7d1l+xzGW8v2qeLCfoNLA3t6bLPCtNkBeHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RVa363czG6pBOaxQ1rGQVbk2CzjzKweUYstHYsK5rD7POD1odipHd7bUmmY16Dhdj v5hUg7N2uqiPGC7iVtX2J/S3IrTOt/m6NPo/X3m2fpLGNXovaAyP016egJA+37i45b xwpFX1iBkULMbQH6SwjOhojLVsk7tQdOug+7/9vc= Date: Mon, 9 Oct 2023 17:21:30 +0200 From: Greg Kroah-Hartman To: Krishna Kurapati PSSNV Cc: Maciej =?utf-8?Q?=C5=BBenczykowski?= , onathan Corbet , Linyu Yuan , linux-usb@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, quic_ppratap@quicinc.com, quic_wcheng@quicinc.com, quic_jackp@quicinc.com Subject: Re: [PATCH 1/2] Documentation: usb: Update NCM configfs parameters Message-ID: <2023100954-steadier-discolor-084f@gregkh> References: <20231009142005.21338-1-quic_kriskura@quicinc.com> <2023100942-drop-down-abide-f8fe@gregkh> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Oct 09, 2023 at 08:40:27PM +0530, Krishna Kurapati PSSNV wrote: > > > On 10/9/2023 8:35 PM, Greg Kroah-Hartman wrote: > > On Mon, Oct 09, 2023 at 07:50:04PM +0530, Krishna Kurapati wrote: > > > Updateed NCM configfs parameters by adding max_segment_size > > > property and describing its effect on MTU configuration of > > > NCM interface. > > > > "Updated"? > > My bad. Will fix it in v2. > > > > > > > > Signed-off-by: Krishna Kurapati > > > --- > > > Documentation/usb/gadget-testing.rst | 20 +++++++++++--------- > > > 1 file changed, 11 insertions(+), 9 deletions(-) > > > > > > diff --git a/Documentation/usb/gadget-testing.rst b/Documentation/usb/gadget-testing.rst > > > index 29072c166d23..6e5d96668e8e 100644 > > > --- a/Documentation/usb/gadget-testing.rst > > > +++ b/Documentation/usb/gadget-testing.rst > > > @@ -448,15 +448,17 @@ Function-specific configfs interface > > > The function name to use when creating the function directory is "ncm". > > > The NCM function provides these attributes in its function directory: > > > - =============== ================================================== > > > - ifname network device interface name associated with this > > > - function instance > > > - qmult queue length multiplier for high and super speed > > > - host_addr MAC address of host's end of this > > > - Ethernet over USB link > > > - dev_addr MAC address of device's end of this > > > - Ethernet over USB link > > > - =============== ================================================== > > > + ================= ==================================================== > > > + ifname network device interface name associated with this > > > + function instance > > > + qmult queue length multiplier for high and super speed > > > + host_addr MAC address of host's end of this > > > + Ethernet over USB link > > > + dev_addr MAC address of device's end of this > > > + Ethernet over USB link > > > + max_segment_size Segment size required for P2P connections. This > > > + will inturn set MTU to (max_segment_size - 14 bytes) > > > > "inturn"??? > > > > > + ================= ==================================================== > > > > What commit id does this fix? > > > This is not a bug fix. It is just an addition of a new property. Does it > need a fixes tag ? Where is the code for the new property? Ah, it's in patch 2/2, that wasn't obvious, sorry. Why is this a separate patch at all, shouldn't be part of the commit that adds the new property to the system? thanks, greg k-h