From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: core: Minor improvements to usb_hub_create_port_device
Date: Tue, 17 Oct 2023 18:59:01 +0200 [thread overview]
Message-ID: <2023101726-popper-shortlist-4065@gregkh> (raw)
In-Reply-To: <4793f68e-cb16-4058-9704-230ae0e32b8e@gmail.com>
On Tue, Oct 17, 2023 at 06:43:51PM +0200, Heiner Kallweit wrote:
> Minor improvements, no functional change intended.
> - Use variable hdev instead of hub->hdev
> - Don't call hub_is_superspeed() twice
> - Style fix for else clause
Please do not do multiple things in the same patch. These need to be
all broken up into "one patch per logical change" to be able to properly
review and potentially revert them in the future.
thanks,
greg k-h
prev parent reply other threads:[~2023-10-17 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 16:43 [PATCH] usb: core: Minor improvements to usb_hub_create_port_device Heiner Kallweit
2023-10-17 16:59 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101726-popper-shortlist-4065@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox