From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
"Li, Meng" <Meng.Li@windriver.com>,
Ingo Molnar <mingo@redhat.com>,
USB mailing list <linux-usb@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: USB: add check to detect host controller hardware removal
Date: Thu, 19 Oct 2023 14:49:53 +0200 [thread overview]
Message-ID: <20231019124953.kxpuDCgt@linutronix.de> (raw)
In-Reply-To: <20231016125624.1096766a@gandalf.local.home>
On 2023-10-16 12:56:24 [-0400], Steven Rostedt wrote:
> On Fri, 13 Oct 2023 13:17:52 -0400
> Alan Stern <stern@rowland.harvard.edu> wrote:
>
> Because in RT, spin_lock()s are actually mutexes.
>
> In RT, interrupt handlers do not even run with interrupts disabled (they
> run as threads), so the assumption that they run with interrupts disabled
> on RT is incorrect. One hack would simply be:
>
> if (!IS_ENABLED(CONFIG_PREEMPT_RT))
> local_irq_disable();
> usb_hcd_irq(0, hcd);
> if (!IS_ENABLED(CONFIG_PREEMPT_RT))
> local_irq_enable();
>
> But that's rather ugly. We use to have that as a wrapper of just:
>
> local_irq_disable_nort();
>
> but I don't know if we removed that or not.
>
> Sebastian?
Got removed once it had zero users. It was hated because it was used
usually used as a quick solution to hide problems underneath.
> -- Steve
Sebastian
prev parent reply other threads:[~2023-10-19 12:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PH0PR11MB5191464B2F01511D2ADECB3BF1D2A@PH0PR11MB5191.namprd11.prod.outlook.com>
2023-10-13 17:17 ` USB: add check to detect host controller hardware removal Alan Stern
2023-10-15 13:37 ` Li, Meng
2023-10-16 16:56 ` Steven Rostedt
2023-10-16 19:23 ` Alan Stern
2023-10-17 2:23 ` Li, Meng
2023-10-17 14:06 ` Alan Stern
2023-10-18 5:00 ` Li, Meng
2023-10-18 15:20 ` Alan Stern
2023-10-18 15:34 ` Alan Stern
2023-10-19 12:38 ` Sebastian Andrzej Siewior
2023-10-19 15:09 ` Alan Stern
2023-10-19 15:27 ` Alan Stern
2023-10-20 9:52 ` Sebastian Andrzej Siewior
2023-10-20 15:19 ` Alan Stern
2023-11-03 15:46 ` Sebastian Andrzej Siewior
2023-11-03 20:42 ` Alan Stern
2023-11-06 3:02 ` Li, Meng
2023-11-06 8:28 ` Sebastian Andrzej Siewior
2023-11-06 8:54 ` Li, Meng
2023-11-06 9:09 ` Sebastian Andrzej Siewior
2023-11-07 3:08 ` Li, Meng
2023-11-07 6:17 ` Greg KH
2023-11-06 15:25 ` Alan Stern
2023-11-06 8:27 ` Sebastian Andrzej Siewior
2023-10-19 12:49 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019124953.kxpuDCgt@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Meng.Li@windriver.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox