From: Peter Chen <peter.chen@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel test robot <lkp@intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: chipidea: Fix unused ci_hdrc_usb2_of_match warning for !CONFIG_OF
Date: Fri, 20 Oct 2023 09:55:47 +0800 [thread overview]
Message-ID: <20231020015547.GA1119400@nchen-desktop> (raw)
In-Reply-To: <20231019183015.841460-1-robh@kernel.org>
On 23-10-19 13:30:15, Rob Herring wrote:
> Commit 14485de431b0 ("usb: Use device_get_match_data()") dropped the
> unconditional use of ci_hdrc_usb2_of_match resulting in this warning:
>
> drivers/usb/chipidea/ci_hdrc_usb2.c:41:34: warning: unused variable 'ci_hdrc_usb2_of_match' [-Wunused-const-variable]
>
> The fix is to drop of_match_ptr() which is not necessary because DT is
> always used for this driver.
>
> Fixes: 14485de431b0 ("usb: Use device_get_match_data()")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310131627.M43j234A-lkp@intel.com/
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Peter Chen <peter.chen@kernel.org>
> ---
> drivers/usb/chipidea/ci_hdrc_usb2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
> index 180a632dd7ba..97379f653b06 100644
> --- a/drivers/usb/chipidea/ci_hdrc_usb2.c
> +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
> @@ -119,7 +119,7 @@ static struct platform_driver ci_hdrc_usb2_driver = {
> .remove_new = ci_hdrc_usb2_remove,
> .driver = {
> .name = "chipidea-usb2",
> - .of_match_table = of_match_ptr(ci_hdrc_usb2_of_match),
> + .of_match_table = ci_hdrc_usb2_of_match,
> },
> };
> module_platform_driver(ci_hdrc_usb2_driver);
> --
> 2.42.0
>
--
Thanks,
Peter Chen
prev parent reply other threads:[~2023-10-20 1:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 18:30 [PATCH] usb: chipidea: Fix unused ci_hdrc_usb2_of_match warning for !CONFIG_OF Rob Herring
2023-10-20 1:55 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020015547.GA1119400@nchen-desktop \
--to=peter.chen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox