From: Manan Aurora <maurora@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Badhri Jagan Sridharan <badhri@google.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
manugautam@google.com, Manan Aurora <maurora@google.com>
Subject: [PATCH] usb: gadget: Support transfers from device memory
Date: Tue, 31 Oct 2023 03:54:02 +0000 [thread overview]
Message-ID: <20231031035403.661938-1-maurora@google.com> (raw)
USB gadget stack only supports usb_request objects that point to buffers
located in memory. Support use cases where data is transferred from
physical addresses in device mmio regions
Added a bit "pre_mapped" to usb_request to bypass dma_map_single and
dma_map_sg for such requests
The caller must determine the dma address for the request before queuing
it
Signed-off-by: Manan Aurora <maurora@google.com>
---
drivers/usb/gadget/udc/core.c | 4 ++--
include/linux/usb/gadget.h | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index ded9531f141b..236165ba08f4 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -900,7 +900,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_activate);
int usb_gadget_map_request_by_dev(struct device *dev,
struct usb_request *req, int is_in)
{
- if (req->length == 0)
+ if (req->pre_mapped || req->length == 0)
return 0;
if (req->num_sgs) {
@@ -948,7 +948,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_map_request);
void usb_gadget_unmap_request_by_dev(struct device *dev,
struct usb_request *req, int is_in)
{
- if (req->length == 0)
+ if (req->pre_mapped || req->length == 0)
return;
if (req->num_mapped_sgs) {
diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
index a771ccc038ac..6bc035439098 100644
--- a/include/linux/usb/gadget.h
+++ b/include/linux/usb/gadget.h
@@ -111,6 +111,7 @@ struct usb_request {
unsigned zero:1;
unsigned short_not_ok:1;
unsigned dma_mapped:1;
+ unsigned pre_mapped:1;
void (*complete)(struct usb_ep *ep,
struct usb_request *req);
--
2.42.0.820.g83a721a137-goog
next reply other threads:[~2023-10-31 3:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 3:54 Manan Aurora [this message]
2023-10-31 6:00 ` [PATCH] usb: gadget: Support transfers from device memory Greg Kroah-Hartman
2023-10-31 14:27 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031035403.661938-1-maurora@google.com \
--to=maurora@google.com \
--cc=badhri@google.com \
--cc=francesco.dolcini@toradex.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manugautam@google.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox