From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Wentong Wu <wentong.wu@intel.com>,
Oliver Neukum <oneukum@suse.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: misc: ljca: Fix enumeration error on Dell Latitude 9420
Date: Thu, 2 Nov 2023 19:13:32 +0100 [thread overview]
Message-ID: <2023110216-straggler-marbles-b760@gregkh> (raw)
In-Reply-To: <841a0653-15ed-268f-d702-c97be7482ca8@redhat.com>
On Thu, Nov 02, 2023 at 07:05:33PM +0100, Hans de Goede wrote:
> >
> >> ret = ljca_send(adap, LJCA_CLIENT_MNG, LJCA_MNG_ENUM_SPI, NULL, 0, buf,
> >> sizeof(buf), true, LJCA_ENUM_CLIENT_TIMEOUT_MS);
> >> if (ret < 0)
> >> - return ret;
> >> + return (ret == -ETIMEDOUT) ? 0 : ret;
> >
> > I don't think the parens are necessary.
>
> They are not strictly necessary, but IMHO the code is more readable with
> the parens.
I agree, please leave it in.
thanks,
greg k-h
prev parent reply other threads:[~2023-11-02 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 16:48 [PATCH] usb: misc: ljca: Fix enumeration error on Dell Latitude 9420 Hans de Goede
2023-11-02 17:25 ` Sergei Shtylyov
2023-11-02 18:05 ` Hans de Goede
2023-11-02 18:13 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023110216-straggler-marbles-b760@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andi.shyti@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sergei.shtylyov@gmail.com \
--cc=wentong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox