From: Greg KH <gregkh@linuxfoundation.org>
To: Roy Luo <royluo@google.com>
Cc: stern@rowland.harvard.edu, badhri@google.com,
quic_kriskura@quicinc.com, francesco.dolcini@toradex.com,
quic_eserrao@quicinc.com, ivan.orlov0322@gmail.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] USB: gadget: core: adjust uevent timing on gadget unbind
Date: Wed, 22 Nov 2023 22:07:15 +0000 [thread overview]
Message-ID: <2023112253-fresh-blazing-baae@gregkh> (raw)
In-Reply-To: <20231122220001.539770-1-royluo@google.com>
On Wed, Nov 22, 2023 at 10:00:01PM +0000, Roy Luo wrote:
> The KOBJ_CHANGE uevent is sent before gadget unbind is actually
> executed, resulting in inaccurate uevent emitted at incorrect timing
> (the uevent would have USB_UDC_DRIVER variable set while it would
> soon be removed).
> Move the KOBJ_CHANGE uevent to the end of the unbind function so that
> uevent is sent only after the change has been made.
>
> Signed-off-by: Roy Luo <royluo@google.com>
> ---
> drivers/usb/gadget/udc/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
What commit does this fix?
next prev parent reply other threads:[~2023-11-22 22:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 22:00 [PATCH v1] USB: gadget: core: adjust uevent timing on gadget unbind Roy Luo
2023-11-22 22:07 ` Greg KH [this message]
2023-11-22 23:13 ` Roy Luo
2023-11-23 8:52 ` Greg KH
2023-11-27 19:48 ` Roy Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023112253-fresh-blazing-baae@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=badhri@google.com \
--cc=francesco.dolcini@toradex.com \
--cc=ivan.orlov0322@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_eserrao@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=royluo@google.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).