From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Sanath S <Sanath.S@amd.com>,
andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [Patch v2] thunderbolt: Add quirk to reset downstream port
Date: Thu, 23 Nov 2023 08:00:04 +0200 [thread overview]
Message-ID: <20231123060004.GA1074920@black.fi.intel.com> (raw)
In-Reply-To: <95ceae27-f88d-4915-870a-36cf9418f244@amd.com>
On Wed, Nov 22, 2023 at 09:43:55AM -0600, Mario Limonciello wrote:
> On 11/22/2023 00:03, Mika Westerberg wrote:
> > Hi,
> >
> > On Wed, Nov 22, 2023 at 10:36:39AM +0530, Sanath S wrote:
> > > Boot firmware on AMD's Yellow Carp and Pink Sardine allocates
> > > very minimal buses for PCIe downstream ports. This results in
> > > failure to extend the daisy chain.
> > >
> > > Add quirk to reset the downstream port to help reset the topology
> > > created by boot firmware.
> >
> > But this resets the USB4 side of ports, how does this help with the PCIe
> > side? Or this also resets the PCIe side? Please add this information to
> > the changelog too.
>
> IIUC the PCIe side will be implicitly reset as well.
>
> >
> > I suppose it is not possible to fix the boot firmware?
>
> It's a really difficult case to make with firmware team. Windows and Linux
> have a different behavior here. The Windows CM doesn't take the existing
> tunnels from firmware and instead always resets them.
> So Windows "isn't affected" by this problem.
>
> Furthermore there are already lots of systems out "in the wild" as these are
> already both production silicon with shipping OEM products.
Yeah that's what I was afraid :( Okay we've been there before so let's
work it around in the kernel then.
prev parent reply other threads:[~2023-11-23 6:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 5:06 [Patch v2] thunderbolt: Add quirk to reset downstream port Sanath S
2023-11-22 6:03 ` Mika Westerberg
2023-11-22 7:32 ` Mika Westerberg
2023-11-22 15:43 ` Mario Limonciello
2023-11-23 5:16 ` Sanath S
2023-11-23 6:05 ` Mika Westerberg
2023-11-23 6:23 ` Mario Limonciello
2023-11-23 6:57 ` Mika Westerberg
2023-11-23 6:00 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123060004.GA1074920@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Sanath.S@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).