public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
To: stern@rowland.harvard.edu, oneukum@suse.com
Cc: davem@davemloft.net, edumazet@google.com, jtornosm@redhat.com,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	pabeni@redhat.com
Subject: Re: [PATCH] net: usb: ax88179_178a: avoid failed operations when device is disconnected
Date: Thu, 30 Nov 2023 09:41:36 +0100	[thread overview]
Message-ID: <20231130084136.172052-1-jtornosm@redhat.com> (raw)
In-Reply-To: <51cb747a-21fe-4b3b-9567-01b9cc9d8873@rowland.harvard.edu>

Hi Oliver,

> I am sorry, but this is a layering violation. You are looking
> at an internal state of the USB layer to surpress logging
> -ENODEV. If you think these messages should go away, filter
> for ENODEV where they are generated.
Thank you for your comments and suggestion.
My intention was also to avoid unnecessary and failed operations 
if disconnection was detected.
Ok, let me research more and do better.

Hi Alan,

> In addition, you should be more careful about the distinction between 
> "unbound" and "disconnected".  It's possible for the driver to be 
> unbound from the device even while the device is still plugged in.  In 
> this situation, submitting URBs will fail with an error even though the 
> device state isn't USB_STATE_NOTATTACHED.
Thank you for you comments.
I also tested "unbound" and stop and unbind operations were correctly 
executed. I just wanted to avoid the issues during disconnection, if other 
operations are commanded later I think it is better to warn.
Ok, I will try to do better.

Best regards
Jose Ignacio


  reply	other threads:[~2023-11-30  8:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 15:16 [PATCH] net: usb: ax88179_178a: avoid failed operations when device is disconnected Jose Ignacio Tornos Martinez
2023-11-29 15:33 ` Oliver Neukum
2023-11-29 15:40   ` Alan Stern
2023-11-30  8:41     ` Jose Ignacio Tornos Martinez [this message]
2023-11-30 15:50       ` Alan Stern
2023-11-30 17:25         ` Jose Ignacio Tornos Martinez
2023-11-30 18:13           ` Alan Stern
2023-12-01 10:46             ` Jose Ignacio Tornos Martinez
2023-12-01 11:51             ` [PATCH v2] " Jose Ignacio Tornos Martinez
2023-12-01 12:25               ` Greg KH
2023-12-01 13:26                 ` [PATCH v3] " Jose Ignacio Tornos Martinez
2023-12-01 16:13                   ` Alan Stern
2023-12-01 17:27                     ` Jose Ignacio Tornos Martinez
2023-12-01 20:14                   ` Oliver Neukum
2023-12-04 11:31                     ` Jose Ignacio Tornos Martinez
2023-12-05 13:51                     ` [PATCH v4] " Jose Ignacio Tornos Martinez
2023-12-05 18:07                       ` Alan Stern
2023-12-06 12:17                         ` Jose Ignacio Tornos Martinez
2023-12-07 11:42                         ` [PATCH v5] " Jose Ignacio Tornos Martinez
2023-12-07 16:41                           ` Alan Stern
2023-12-07 17:50                             ` [PATCH v6] " Jose Ignacio Tornos Martinez
2023-12-07 20:23                               ` Alan Stern
2023-12-07 20:32                                 ` Jakub Kicinski
2023-12-08  4:56                                   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231130084136.172052-1-jtornosm@redhat.com \
    --to=jtornosm@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=pabeni@redhat.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox