From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Johan Hovold <johan@kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
USB list <linux-usb@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: question on correct error return from break_ctl()
Date: Thu, 30 Nov 2023 14:42:20 +0000 [thread overview]
Message-ID: <2023113053-oxidize-observant-9fb8@gregkh> (raw)
In-Reply-To: <0dd783e9-1cd2-467f-a90d-e63fec88350c@suse.com>
On Thu, Nov 30, 2023 at 03:36:21PM +0100, Oliver Neukum wrote:
> On 30.11.23 14:48, Greg Kroah-Hartman wrote:
> Hi,
>
> > usb-serial should probably change, but given the fact that no one has
> > noticed this in the 20+ years it has been like this, is it really
> > needed? :)
>
> I am afraid I need to point out that usb-serial has been changed _this_ _year_
> to return -ENOTTY. CDC-ACM being also in this situation unfortunately
> I need to decide between one of the alternatives.
Ah, oops, then it should probably be changed back. Unless Johan, any
specific reason this was changed?
thanks,
greg k-h
next prev parent reply other threads:[~2023-11-30 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 13:09 question on correct error return from break_ctl() Oliver Neukum
2023-11-30 13:48 ` Greg Kroah-Hartman
2023-11-30 14:36 ` Oliver Neukum
2023-11-30 14:42 ` Greg Kroah-Hartman [this message]
2023-11-30 15:12 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023113053-oxidize-observant-9fb8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox