From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="J5FlfAu9" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22C5D1B5; Tue, 5 Dec 2023 23:00:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701846045; x=1733382045; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MxqLA5pxAlyS9f99ErxXmlln8s3f6yh2wue/tkIXCWA=; b=J5FlfAu9ziGdoI6YFYkwRfSHXniunm9BDYZb62lftNoDA+M2NzC/qDh5 tpajh+jS9Rx83v5tyP0bUtzjdXJ175I53LjMhXuIHefHd+xKWAg5mNzL6 iMZNYaZXXFrY7UkM1BYUDJ84MjjiSrLgsh4hwP7Cul7W0yifIXDL3p5Tp 7VsqUB6X+7haYlvRdT6ec0cPf54OZRAaXfKjk8ujhLgnzKf7QO7Mo2Xxq r8srIt1JmxznPVWBEEV8rREG6j1PKW9XiWePW14RREibkNlXccjQnBBfs hXz6cM4qeG1zjYGszXvhIphZuLEpnfj+XqnVx2ZRIDPNrhB4eQ5NGLfuS A==; X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="12732811" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="12732811" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 23:00:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="720981616" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="720981616" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by orsmga003.jf.intel.com with ESMTP; 05 Dec 2023 23:00:42 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rAltg-000AR0-0c; Wed, 06 Dec 2023 07:00:40 +0000 Date: Wed, 6 Dec 2023 15:00:23 +0800 From: kernel test robot To: Simon Holesch , Valentina Manea , Shuah Khan , Hongren Zheng , Greg Kroah-Hartman Cc: oe-kbuild-all@lists.linux.dev, Simon Holesch , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] usbip: Don't submit special requests twice Message-ID: <202312061416.KFbIrElk-lkp@intel.com> References: <20231130231650.22410-1-simon@holesch.de> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231130231650.22410-1-simon@holesch.de> Hi Simon, kernel test robot noticed the following build errors: [auto build test ERROR on usb/usb-testing] [also build test ERROR on usb/usb-next usb/usb-linus linus/master v6.7-rc4 next-20231206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Simon-Holesch/usbip-Don-t-submit-special-requests-twice/20231201-072027 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing patch link: https://lore.kernel.org/r/20231130231650.22410-1-simon%40holesch.de patch subject: [PATCH v3] usbip: Don't submit special requests twice config: hexagon-randconfig-r081-20231201 (https://download.01.org/0day-ci/archive/20231206/202312061416.KFbIrElk-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312061416.KFbIrElk-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202312061416.KFbIrElk-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from drivers/usb/usbip/stub_rx.c:8: In file included from include/linux/usb.h:16: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:337: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 547 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from drivers/usb/usbip/stub_rx.c:8: In file included from include/linux/usb.h:16: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:337: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from drivers/usb/usbip/stub_rx.c:8: In file included from include/linux/usb.h:16: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:337: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 584 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ >> drivers/usb/usbip/stub_rx.c:158:51: error: expected ';' after expression 158 | err = usb_lock_device_for_reset(sdev->udev, NULL) | ^ | ; 6 warnings and 1 error generated. vim +158 drivers/usb/usbip/stub_rx.c 149 150 static int tweak_reset_device_cmd(struct urb *urb) 151 { 152 struct stub_priv *priv = (struct stub_priv *) urb->context; 153 struct stub_device *sdev = priv->sdev; 154 int err; 155 156 dev_info(&urb->dev->dev, "usb_queue_reset_device\n"); 157 > 158 err = usb_lock_device_for_reset(sdev->udev, NULL) 159 if (err < 0) { 160 dev_err(&urb->dev->dev, "could not obtain lock to reset device\n"); 161 return err; 162 } 163 err = usb_reset_device(sdev->udev); 164 usb_unlock_device(sdev->udev); 165 166 return err; 167 } 168 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki