From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D351F5D4A5 for ; Tue, 12 Dec 2023 11:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Y3aY10B2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BF18C433C8; Tue, 12 Dec 2023 11:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702381522; bh=W+wu89yS6ISCTJNOIGobljSOiLONbTsNZcOU+gHhOC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y3aY10B2veYLe39QbwiYhKctBqWU8+cZIFtuv8UrnHy7ioljgw+VVW/xAlNjlKfN2 B2WnPBwXc/oNFPrFR2vlf6kGBIrDUmXXWXG+4P3vtUSvEp5aa4zPgdvg2FvtTcrLJH 5ncaF+llV88ZZGQLVK7doz79ajaV9ARwFxKCa/o0= Date: Tue, 12 Dec 2023 12:45:20 +0100 From: Greg KH To: shitao Cc: alcooperx@gmail.com, chunfeng.yun@mediatek.com, justin.chen@broadcom.com, kernel-bot@kylinos.cn, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: mtu3: fix comment typo Message-ID: <2023121208-tattoo-grief-a78b@gregkh> References: <2023121216-shabby-hastily-f094@gregkh> <20231212110959.3115422-1-shitao@kylinos.cn> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212110959.3115422-1-shitao@kylinos.cn> On Tue, Dec 12, 2023 at 07:09:59PM +0800, shitao wrote: > Reported-by: k2ci > Signed-off-by: shitao > --- > Hi, > according to your suggestion, I have split it into two patches and added some simple instructions. > This is about fixing the misspelling of "empty" in the mtu3_qmu.c file. > thanks. > drivers/usb/mtu3/mtu3_qmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c > index 3d77408e3133..03f26589b056 100644 > --- a/drivers/usb/mtu3/mtu3_qmu.c > +++ b/drivers/usb/mtu3/mtu3_qmu.c > @@ -221,7 +221,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring) > return ring->dequeue; > } > > -/* check if a ring is emtpy */ > +/* check if a ring is empty */ > static bool gpd_ring_empty(struct mtu3_gpd_ring *ring) > { > struct qmu_gpd *enq = ring->enqueue; > -- > 2.34.1 > I would strongly suggest that you practice kernel patches in the drivers/staging/ portion of the kernel, as that is where people learn how to do this properly, and not bother other subsystems or developers. Please start there and learn the basics, and then you can move to other portions of the kernel as you will not be making simple mistakes like you are here (hint, you forgot to version your patch, AND you forgot a changelog...) thanks, greg k-h