public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: linux-usb@vger.kernel.org, Wendy Wang <wendy.wang@intel.com>
Subject: Re: [PATCH 1/1] xhci: Fix null pointer dereference during S4 resume when resetting ep0
Date: Fri, 15 Dec 2023 18:27:24 +0100	[thread overview]
Message-ID: <2023121515-paper-annuity-a0e3@gregkh> (raw)
In-Reply-To: <20231215125707.1732989-2-mathias.nyman@linux.intel.com>

On Fri, Dec 15, 2023 at 02:57:07PM +0200, Mathias Nyman wrote:
> During device enumeration usb core resets endpoint 0 if the max packet
> size value differs from the one read from the device descriptor.
> 
> usb core will additionally reset endpoint 0 during S4 resume, before
> re-enumerating the device, if the device has a reset-resume flag set.
> 
> In this case the xhci device representation vdev may be lost due to
> xHC restore error and re-initialization during S4 resume.
> 
> Make sure slot_id and vdev are valid before trying to re-configure max
> packet size during endpoint 0 reset.
> max packet size will be re-configured later during re-enumeration.
> 
> This fixes commit e34900f46cd6 ("xhci: Reconfigure endpoint 0 max packet
> size only during endpoint reset") which is currently in usb-next,
> on its way to 6.7

You mean "6.8" here, right?

thanks,

greg k-h

  reply	other threads:[~2023-12-15 17:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15 12:57 [PATCH 0/1] xhci feature-fix for usb-next Mathias Nyman
2023-12-15 12:57 ` [PATCH 1/1] xhci: Fix null pointer dereference during S4 resume when resetting ep0 Mathias Nyman
2023-12-15 17:27   ` Greg KH [this message]
2023-12-18  9:29     ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023121515-paper-annuity-a0e3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=wendy.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox