From: Werner Sembach <wse@tuxedocomputers.com>
To: Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>
Cc: Werner Sembach <wse@tuxedocomputers.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] thunderbolt: Reduce retry timeout to speed up boot for some devices
Date: Wed, 20 Dec 2023 16:09:56 +0100 [thread overview]
Message-ID: <20231220150956.230227-1-wse@tuxedocomputers.com> (raw)
This is a followup to "thunderbolt: Workaround an IOMMU fault on certain
systems with Intel Maple Ridge".
It seems like the timeout can be reduced to 250ms. This reduces the overall
delay caused by the retires to ~1s. This is about the time other things
being initialized in parallel need anyway*, so like this the effective boot
time is no longer compromised.
*I only had a single device available for my measurements: A Clevo X170KM-G
desktop replacement notebook.
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
drivers/thunderbolt/icm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
index d8b9c734abd36..56790d50f9e32 100644
--- a/drivers/thunderbolt/icm.c
+++ b/drivers/thunderbolt/icm.c
@@ -1020,7 +1020,7 @@ icm_tr_driver_ready(struct tb *tb, enum tb_security_level *security_level,
memset(&reply, 0, sizeof(reply));
ret = icm_request(tb, &request, sizeof(request), &reply, sizeof(reply),
- 1, 10, 2000);
+ 1, 10, 250);
if (ret)
return ret;
--
2.34.1
next reply other threads:[~2023-12-20 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 15:09 Werner Sembach [this message]
2023-12-20 15:23 ` [PATCH] thunderbolt: Reduce retry timeout to speed up boot for some devices Werner Sembach
2023-12-20 16:04 ` Greg KH
2023-12-20 16:23 ` Werner Sembach
2023-12-20 16:41 ` Werner Sembach
2023-12-20 17:30 ` Greg KH
2023-12-21 10:37 ` Mika Westerberg
2023-12-21 12:20 ` Werner Sembach
2023-12-22 11:03 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220150956.230227-1-wse@tuxedocomputers.com \
--to=wse@tuxedocomputers.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox