From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21A3E47A59; Wed, 20 Dec 2023 17:37:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kroah.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="aXXh4QTI"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="MrbqF/6E" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 19A265C0442; Wed, 20 Dec 2023 12:37:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 20 Dec 2023 12:37:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1703093839; x=1703180239; bh=GnEOfo/anO WPxQKbFe9WTvHxFyLYv0rH36Sgz3O76EA=; b=aXXh4QTI7ED5bSnleEslOsioM6 YoRDVZ74YnQU0cOVdLvloTPUot0eUYa9XmQmN2yJx4fAfiTwaglQJkyS6T9A2Qu6 ZcY7a9HqWaMNV9Q5HKOpvH8p7dlXvfR4CPRtKfCl/23egGabG3cRvXr75CA1wlr1 MdcukxgH1L+piPaDe2wcRI4ojzltu5/v/EDHMiFghTnk/ifNQS564GvqhgDnp0/Z GgxGZBSLZeCP/l5n73prVvhcGKW8mW3EqCa5Rji5SZI05knYJyofk6yyxCTG3V3e 46/iRm0XjzN+Ja5gNL4UlxRA25HCshD6dwMIAL1C05GF6tm74rbKqc6QsjZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703093839; x=1703180239; bh=GnEOfo/anOWPxQKbFe9WTvHxFyLY v0rH36Sgz3O76EA=; b=MrbqF/6ESfm7v+lfWAl0Y0jTu/CYn+TBctauTik8BT2c 8ycFNg7CxokRozm2bz5/a0Zbk2b2m8T7MHqmKAOimGo+2v0KoBc1+SIUZD5/Hn9n 10B4A51PojaiUhTrQ59PGLpzq1ewmYWiFk/xD19o4K7n3D0PUrNWvqXqd+hF0sxA mLrzINgcPEUAv7ivEn5R9kHIypeJZ92R1CNPM3iHOJxdw99jhlbhHu/Om5RelZst rBVKty6LELb2Jikz7Idi0t51yRAX2OPIUJEejA3rZgVf6ua2bea/2X97xKH8Bnmq k1Iq+iCgxHJl6fnVioatlu8zfi/5lVc8cjqn+MPxwQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdduvddguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgv ghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeehge dvvedvleejuefgtdduudfhkeeltdeihfevjeekjeeuhfdtueefhffgheekteenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhroh grhhdrtghomh X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Dec 2023 12:37:18 -0500 (EST) Date: Wed, 20 Dec 2023 18:30:53 +0100 From: Greg KH To: Werner Sembach Cc: Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thunderbolt: Reduce retry timeout to speed up boot for some devices Message-ID: <2023122056-snowflake-visor-1262@gregkh> References: <20231220150956.230227-1-wse@tuxedocomputers.com> <2e00a0dc-5911-44ee-8c50-a8482eb44197@tuxedocomputers.com> <2023122012-spruce-unsteady-e187@gregkh> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 20, 2023 at 05:41:01PM +0100, Werner Sembach wrote: > > Am 20.12.23 um 17:04 schrieb Greg KH: > > On Wed, Dec 20, 2023 at 04:23:15PM +0100, Werner Sembach wrote: > > > Am 20.12.23 um 16:09 schrieb Werner Sembach: > > > > This is a followup to "thunderbolt: Workaround an IOMMU fault on certain > > > > systems with Intel Maple Ridge". > > > > > > > > It seems like the timeout can be reduced to 250ms. This reduces the overall > > > > delay caused by the retires to ~1s. This is about the time other things > > > > being initialized in parallel need anyway*, so like this the effective boot > > > > time is no longer compromised. > > > > > > > > *I only had a single device available for my measurements: A Clevo X170KM-G > > > > desktop replacement notebook. > > > > > > > > Signed-off-by: Werner Sembach > > > I wonder if this could also land in stable? Or would it be to risky? > > If it's really a bugfix now, why would it _not_ be relevant for stable? > > Because it changes a timeout that could cause issues if set to low: This > Patch sets to to 250ms. Set to 50ms it causes issues, currently it's 2000ms, > 2 people tested that 250ms is enough, but i don't know if this is a big > enough sample size for stable. Remember, the next kernel will be a stable kernel tree, just like the one after that. If it's good enough for Linus's tree, why wouldn't it be good enough for all stable trees? Either it works or it doesn't, none of this "we will break things when you move to a new kernel" stuff please. thanks, greg k-h