From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Roger Quadros <rogerq@kernel.org>,
Javier Carrasco <javier.carrasco@wolfvision.net>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tipd: fix use of device-specific init function
Date: Fri, 5 Jan 2024 13:53:09 +0100 [thread overview]
Message-ID: <2024010558-unhappy-scandal-b823@gregkh> (raw)
In-Reply-To: <56a15164-dbce-4740-b59e-b566f613f878@gmail.com>
On Fri, Jan 05, 2024 at 01:42:47PM +0100, Javier Carrasco wrote:
> On 05.01.24 13:36, Heikki Krogerus wrote:
> > On Thu, Jan 04, 2024 at 06:07:12PM +0100, Javier Carrasco wrote:
> >> The current implementation supports device-pecific callbacks for the
> >> init function with a function pointer. The patch that introduced this
> >> feature did not update one call to the tps25750 init function to turn it
> >> into a call with the new pointer in the resume function.
> >>
> >> Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
> >> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> >
> > This was suggested by Roger, no?
> >
>
> Yes, it was. Thanks for the reminder.
>
> Could the following trailer be added before applying?
>
> Suggested-by: Roger Quadros <rogerq@kernel.org>
The tools automatically just added that now, thanks.
greg k-h
prev parent reply other threads:[~2024-01-05 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 17:07 [PATCH] usb: typec: tipd: fix use of device-specific init function Javier Carrasco
2024-01-05 12:36 ` Heikki Krogerus
2024-01-05 12:42 ` Javier Carrasco
2024-01-05 12:53 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024010558-unhappy-scandal-b823@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=javier.carrasco@wolfvision.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox