From: Rob Herring <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
matthias.bgg@gmail.com, linux@roeck-us.net,
heikki.krogerus@linux.intel.com, cy_huang@richtek.com,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 1/2] dt-bindings: usb: mt6360-tcpc: Rename IRQ to PD-IRQB
Date: Fri, 12 Jan 2024 08:20:18 -0600 [thread overview]
Message-ID: <20240112142018.GA3127117-robh@kernel.org> (raw)
In-Reply-To: <20240112094538.65639-1-angelogioacchino.delregno@collabora.com>
On Fri, Jan 12, 2024 at 10:45:37AM +0100, AngeloGioacchino Del Regno wrote:
> Since there is no user yet, rename the only interrupt of this device
> to "PD-IRQB", avoiding underscores.
It is primarily node and property names that have this recommendation,
not so much -names values.
If there is only 1 interrupt, I'd just drop the name.
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> index 053264e60583..0bea23ce2f09 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> @@ -24,7 +24,7 @@ properties:
>
> interrupt-names:
> items:
> - - const: PD_IRQB
> + - const: PD-IRQB
>
> connector:
> type: object
> @@ -58,7 +58,7 @@ examples:
> tcpc {
> compatible = "mediatek,mt6360-tcpc";
> interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
> - interrupt-names = "PD_IRQB";
> + interrupt-names = "PD-IRQB";
>
> connector {
> compatible = "usb-c-connector";
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-01-12 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 9:45 [PATCH 1/2] dt-bindings: usb: mt6360-tcpc: Rename IRQ to PD-IRQB AngeloGioacchino Del Regno
2024-01-12 9:45 ` [PATCH 2/2] usb: typec: tcpci_mt6360: Rename interrupt PD_IRQB " AngeloGioacchino Del Regno
2024-01-12 11:15 ` [PATCH 1/2] dt-bindings: usb: mt6360-tcpc: Rename IRQ " Rob Herring
2024-01-12 14:20 ` Rob Herring [this message]
2024-01-19 9:13 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112142018.GA3127117-robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox