public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Vicki Pfau <vi@endrift.com>
To: linux-usb@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Maxim Devaev <mdevaev@gmail.com>
Cc: Vicki Pfau <vi@endrift.com>, David Sands <david.sands@biamp.com>
Subject: [PATCH v2 0/3] USB: gadget: f_hid: Add Feature reports
Date: Wed, 17 Jan 2024 16:37:54 -0800	[thread overview]
Message-ID: <20240118003758.1870691-1-vi@endrift.com> (raw)

This patchset adds support for Set- and Get-Feature report handling in
the f_hid gadget subsystem.

Following up on a patchset from mid-2022[1] which stalled out due in
part to neither Maxim Devaev nor I properly testing the interaction with
the use_out_ep feature he added at some point, I've revised it based on
Greg's original feedback.

Unfortuantely, it was never quite clear to me how to properly test this
patchset per Maxim's concerns, so I was hoping to resubmit it with
Greg's feedback addressed and see if Maxim is able to test it now.

Note also that this is based on my original patchset, not the revised
version submitted by David Sands[2] at a later point. He may have some
opinions that would make sense to address before anything exposed to
usermode lands.

[1]: https://lore.kernel.org/linux-usb/20220726005824.2817646-1-vi@endrift.com/
[2]: https://lore.kernel.org/linux-usb/20230215231529.2513236-1-david.sands@biamp.com/

Vicki Pfau (3):
  USB: gadget: Move gadget-related ioctl codes to gadget-ioctl.h
  USB: gadget: f_hid: Add Get-Feature report
  USB: gadget: f_hid: Add Set-Feature report

 drivers/usb/gadget/function/f_hid.c   | 231 ++++++++++++++++++++++++--
 include/uapi/linux/usb/g_hid.h        |  19 +++
 include/uapi/linux/usb/g_printer.h    |  23 +--
 include/uapi/linux/usb/g_uvc.h        |   4 +-
 include/uapi/linux/usb/gadget-ioctl.h |  39 +++++
 include/uapi/linux/usb/gadgetfs.h     |  27 +--
 6 files changed, 279 insertions(+), 64 deletions(-)
 create mode 100644 include/uapi/linux/usb/g_hid.h
 create mode 100644 include/uapi/linux/usb/gadget-ioctl.h

-- 
2.43.0


             reply	other threads:[~2024-01-18  0:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18  0:37 Vicki Pfau [this message]
2024-01-18  0:37 ` [PATCH v2 1/3] USB: gadget: Move gadget-related ioctl codes to gadget-ioctl.h Vicki Pfau
2024-01-28  1:34   ` Greg Kroah-Hartman
2024-01-18  0:37 ` [PATCH v2 2/3] USB: gadget: f_hid: Add Get-Feature report Vicki Pfau
2024-01-18  0:37 ` [PATCH v2 3/3] USB: gadget: f_hid: Add Set-Feature report Vicki Pfau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240118003758.1870691-1-vi@endrift.com \
    --to=vi@endrift.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=david.sands@biamp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mdevaev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox