From: Conor Dooley <conor@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, matthias.bgg@gmail.com, linux@roeck-us.net,
heikki.krogerus@linux.intel.com, cy_huang@richtek.com,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names
Date: Tue, 23 Jan 2024 17:14:32 +0000 [thread overview]
Message-ID: <20240123-procurer-jumbo-ebbec485505d@spud> (raw)
In-Reply-To: <12b7b339-498b-45c1-bc5e-05e07660aefa@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
On Mon, Jan 22, 2024 at 11:32:30AM +0100, AngeloGioacchino Del Regno wrote:
> Il 19/01/24 17:32, Conor Dooley ha scritto:
> > On Fri, Jan 19, 2024 at 10:41:04AM +0100, AngeloGioacchino Del Regno wrote:
> > > This IP has only one interrupt, hence interrupt-names is not necessary
> > > to have.
> > > Since there is no user yet, simply remove interrupt-names.
> >
> > I'm a bit confused chief. Patch 2 in this series removes a user of this
> > property from a driver, so can you explain how this statement is true?
> >
> > Maybe I need to drink a few cans of Monster and revisit this patchset?
> >
>
> What I mean with "there is no user" is that there's no device tree with any
> mt6360-tcpc node upstream yet, so there is no meaningful ABI breakage.
> Different story would be if there was a device tree using this already, in
> which case, you can make a required property optional but not remove it.
Not every devicetree lives within the kernel.. If the driver is using
it, I'm not inclined to agree that it should be removed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-01-23 17:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 9:41 [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names AngeloGioacchino Del Regno
2024-01-19 9:41 ` [PATCH v2 2/2] usb: typec: tcpci_mt6360: Retrieve interrupt by index AngeloGioacchino Del Regno
2024-01-19 11:49 ` [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names Rob Herring
2024-01-19 16:32 ` Conor Dooley
2024-01-22 10:32 ` AngeloGioacchino Del Regno
2024-01-23 17:14 ` Conor Dooley [this message]
2024-01-24 8:48 ` AngeloGioacchino Del Regno
2024-01-24 16:18 ` Conor Dooley
2024-01-25 10:32 ` Krzysztof Kozlowski
2024-01-25 11:41 ` AngeloGioacchino Del Regno
2024-01-25 16:57 ` Conor Dooley
2024-01-25 17:02 ` Conor Dooley
2024-01-26 9:15 ` AngeloGioacchino Del Regno
2024-01-26 9:27 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123-procurer-jumbo-ebbec485505d@spud \
--to=conor@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox