From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Prashant Malani <pmalani@chromium.org>,
Abhishek Pandit-Subedi <abhishekpandit@google.com>,
linux-usb@vger.kernel.org, jthies@google.com,
Bjorn Andersson <andersson@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Hans de Goede <hdegoede@redhat.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Saranya Gopal <saranya.gopal@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] usb: typec: ucsi: Limit read size on v1.2
Date: Thu, 25 Jan 2024 15:16:56 -0800 [thread overview]
Message-ID: <2024012525-alienate-frown-916b@gregkh> (raw)
In-Reply-To: <CANFp7mVEF36TCb_4vGbF-0wM-Vn4agT6NXVOrnnDSC0JVpnLmg@mail.gmail.com>
On Wed, Jan 24, 2024 at 10:59:28AM -0800, Abhishek Pandit-Subedi wrote:
> Ack. Will make dev_dbg on the next iteration.
>
> This seems like a good addition to the style guide too:
> https://www.kernel.org/doc/html/v6.7/process/coding-style.html#printing-kernel-messages.
> "When drivers are working properly, they are quiet. Prefer to use
> DEBUG messages unless something is wrong."
>
> What do you think Greg?
I think you need to stop top-posting :)
But yes, that would be nice, hopefully people actually notice it there.
Would you have read this and seen it?
thanks,
greg k-h
next prev parent reply other threads:[~2024-01-25 23:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 22:30 [PATCH v1 0/3] usb: typec: ucsi: Adding support for UCSI 3.0 Abhishek Pandit-Subedi
2024-01-23 22:30 ` [PATCH v1 1/3] usb: typec: ucsi: Limit read size on v1.2 Abhishek Pandit-Subedi
2024-01-24 8:12 ` Prashant Malani
2024-01-24 13:51 ` Heikki Krogerus
2024-01-24 14:17 ` Greg Kroah-Hartman
2024-01-24 18:59 ` Abhishek Pandit-Subedi
2024-01-25 23:16 ` Greg Kroah-Hartman [this message]
2024-01-25 23:37 ` Abhishek Pandit-Subedi
2024-01-23 22:30 ` [PATCH v1 2/3] usb: typec: ucsi: Update connector cap and status Abhishek Pandit-Subedi
2024-01-24 14:14 ` Heikki Krogerus
2024-01-24 18:50 ` Prashant Malani
2024-01-23 22:30 ` [PATCH v1 3/3] usb: typec: ucsi: Get PD revision for partner Abhishek Pandit-Subedi
2024-01-24 14:30 ` Heikki Krogerus
2024-01-24 18:48 ` Prashant Malani
2024-01-24 19:18 ` Abhishek Pandit-Subedi
2024-01-24 19:34 ` Prashant Malani
2024-01-24 22:57 ` Abhishek Pandit-Subedi
2024-01-24 12:44 ` [PATCH v1 0/3] usb: typec: ucsi: Adding support for UCSI 3.0 Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024012525-alienate-frown-916b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abhishekpandit@chromium.org \
--cc=abhishekpandit@google.com \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=pmalani@chromium.org \
--cc=saranya.gopal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox