From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CB8812B8A; Thu, 25 Jan 2024 23:16:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706224619; cv=none; b=GHUPLudzOcFgqoKKHuFlHgePzBf2cvJ6uYUruGRbQjgqMLW7ug0TaRBLB7kksbmKaZIDv0RyviYfxQC7sPtIf19yxdq6R9C5waKeiDDJWN0weDRB/OLrhtU/52nQsoA5verm9gyXMCqQwbs7XIiaZgMfIKa30jtAWq2H+ScLj2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706224619; c=relaxed/simple; bh=w6n+4zYW5jcdy7UBPVyDYjQxKJRG04RqjbfZ0iNojFQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qspafZLn2H3PzHfPf6hLbvVBWJU94Q4BY6yNaQEwJTcAVlINDei+wAB/rGKsQ9OevGmjq7tHUPz7UIjPsxbP4Z8EkdD5NpU5hyYy0TSFfexhKsn02Z9w4+dFxQIx7TVASimesC1+hsNBKXjAJmbO8x+fv/PbvhtzG/9J5mcEdOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=D4YIkH+d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="D4YIkH+d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E184BC433C7; Thu, 25 Jan 2024 23:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706224618; bh=w6n+4zYW5jcdy7UBPVyDYjQxKJRG04RqjbfZ0iNojFQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D4YIkH+dcmFoFF98kqSYLlPEJOBM4/If4VjCt0kvc6RsC+yuM3VldLrHRkOVpnVs0 dCWXZntbw5db1Y9h5LsbgtYEpkngcoFWy2An2FBvGKK+CBD3BUh5OLhbFLgzMrZ8Ej e5ayQWZJpLCWN6h5gpLD0YTBe8GkVbOBPn7iXANE= Date: Thu, 25 Jan 2024 15:16:56 -0800 From: Greg Kroah-Hartman To: Abhishek Pandit-Subedi Cc: Heikki Krogerus , Prashant Malani , Abhishek Pandit-Subedi , linux-usb@vger.kernel.org, jthies@google.com, Bjorn Andersson , Dmitry Baryshkov , Fabrice Gasnier , Hans de Goede , Neil Armstrong , Saranya Gopal , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/3] usb: typec: ucsi: Limit read size on v1.2 Message-ID: <2024012525-alienate-frown-916b@gregkh> References: <20240123223039.1471557-1-abhishekpandit@google.com> <20240123143026.v1.1.Iacf5570a66b82b73ef03daa6557e2fc0db10266a@changeid> <2024012405-stung-freckles-e196@gregkh> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 24, 2024 at 10:59:28AM -0800, Abhishek Pandit-Subedi wrote: > Ack. Will make dev_dbg on the next iteration. > > This seems like a good addition to the style guide too: > https://www.kernel.org/doc/html/v6.7/process/coding-style.html#printing-kernel-messages. > "When drivers are working properly, they are quiet. Prefer to use > DEBUG messages unless something is wrong." > > What do you think Greg? I think you need to stop top-posting :) But yes, that would be nice, hopefully people actually notice it there. Would you have read this and seen it? thanks, greg k-h