From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] platform/x86: Add new MeeGoPad ANX7428 Type-C Cross Switch driver
Date: Mon, 12 Feb 2024 07:35:32 +0000 [thread overview]
Message-ID: <2024021256-retry-moonrise-15d8@gregkh> (raw)
In-Reply-To: <CAHp75VdSWwntsEh5xBz3jzXGi_QRuaRhcSs1-MwG3QYHW=wMtQ@mail.gmail.com>
On Sun, Feb 11, 2024 at 10:50:59PM +0200, Andy Shevchenko wrote:
> > +static struct i2c_driver anx7428_driver = {
> > + .driver = {
> > + .name = KBUILD_MODNAME,
>
> Strictly speaking this is an ABI and we don't want it to be changed in
> case of filename change. Personally I _always_ prefer it be open
> coded.
No, it's not an abi, driver names can, and do, change, nothing should
ever rely on this. So using KBUILD_MODNAME is fine.
thanks,
greg k-h
next prev parent reply other threads:[~2024-02-12 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 19:53 [PATCH] platform/x86: Add new MeeGoPad ANX7428 Type-C Cross Switch driver Hans de Goede
2024-02-11 20:50 ` Andy Shevchenko
2024-02-12 7:35 ` Greg KH [this message]
2024-05-14 15:10 ` Hans de Goede
2024-02-11 21:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024021256-retry-moonrise-15d8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox