From: Greg KH <gregkh@linuxfoundation.org>
To: Selvarasu Ganesan <quic_selvaras@quicinc.com>
Cc: tern@rowland.harvard.edu, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_ppratap@quicinc.com,
quic_wcheng@quicinc.com, quic_jackp@quicinc.com
Subject: Re: [PATCH] usb-storage: Add US_FL_FIX_INQUIRY quirk for Intenso Twist Line USB 3.2
Date: Wed, 14 Feb 2024 14:13:21 +0100 [thread overview]
Message-ID: <2024021402-slit-duke-7761@gregkh> (raw)
In-Reply-To: <20240214111721.18346-1-quic_selvaras@quicinc.com>
On Wed, Feb 14, 2024 at 03:17:21AM -0800, Selvarasu Ganesan wrote:
> The Intenso Twist Line USB 3.2 flash drive fails to respond to the
> INQUIRY data stage request for a 36 bulk in request from the host. This
> commit adds the US_FL_FIX_INQUIRY flag to fake the INQUIRY command for
> this device, preventing a storage enumeration failure.
>
> USBMON log:
> ffffff8a3ee06a00 3192811972 S Ci:2:009:0 s c0 33 0000 0000 0002 2 <
> ffffff8a3ee06a00 3192862051 C Ci:2:009:0 -2 0
> ffffff8a3ee06a00 3192862185 S Ci:2:009:0 s c0 33 0000 0000 0002 2 <
> ffffff8a3ee06a00 3192912299 C Ci:2:009:0 -2 0
> ffffff8a3ee06e00 3193040068 S Ci:2:003:0 s c1 04 0930 bf80 0004 4 <
> ffffff8a3ee06e00 3193040214 C Ci:2:003:0 0 4 = 880b0700
> ffffff8a3ee06e00 3193040279 S Ci:2:002:0 s a3 00 0000 0003 0004 4 <
> ffffff8a3ee06e00 3193040427 C Ci:2:002:0 0 4 = 00010000
> ffffff8a3ee06e00 3193040470 S Ci:2:002:0 s a3 00 0000 0004 0004 4 <
> ffffff8a3ee06e00 3193040672 C Ci:2:002:0 0 4 = 03050000
> ffffff892b309500 3193824092 S Ci:2:009:0 s a1 fe 0000 0000 0001 1 <
> ffffff892b309500 3193824715 C Ci:2:009:0 0 1 = 00
> ffffff892b309500 3193825060 S Bo:2:009:2 -115 31 = 55534243 01000000 24000000 80000612 00000024 00000000 00000000 000000
> ffffff892b309500 3193825150 C Bo:2:009:2 0 31 >
> ffffff8b8419d400 3193825737 S Bi:2:009:1 -115 36 <
> ffffff8a3ee06400 3194040175 S Ci:2:003:0 s c1 04 0930 bf80 0004 4 <
> ffffff8a3ee06400 3194040372 C Ci:2:003:0 0 4 = 880b0700
> ffffff89bee5b100 3194040591 S Ci:2:002:0 s a3 00 0000 0003 0004 4 <
> ffffff89bee5b100 3194040681 C Ci:2:002:0 0 4 = 00010000
> ffffff89bee5b100 3194040999 S Ci:2:002:0 s a3 00 0000 0004 0004 4 <
> ffffff89bee5b100 3194041083 C Ci:2:002:0 0 4 = 03050000
> ffffff8a3ee06a00 3195040349 S Ci:2:003:0 s c1 04 0930 bf80 0004 4 <
>
> Signed-off-by: Selvarasu Ganesan <quic_selvaras@quicinc.com>
> ---
> drivers/usb/storage/unusual_devs.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index fd68204374f2..7285287ca379 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -784,6 +784,13 @@ UNUSUAL_DEV( 0x058f, 0x6387, 0x0141, 0x0141,
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_MAX_SECTORS_64 ),
>
> +/* Selvarasu Ganesan <quic_selvaras@quicinc.com> */
> +UNUSUAL_DEV( 0x058f, 0x6387, 0x0002, 0x0002,
> + "Intenso",
> + "Flash drive",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_FIX_INQUIRY),
> +
Shouldn't this be up an entry to keep them in sorted order?
thanks,
greg k-h
next prev parent reply other threads:[~2024-02-14 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 11:17 [PATCH] usb-storage: Add US_FL_FIX_INQUIRY quirk for Intenso Twist Line USB 3.2 Selvarasu Ganesan
2024-02-14 13:13 ` Greg KH [this message]
2024-02-14 15:04 ` Alan Stern
2024-02-17 5:53 ` Selvarasu Ganesan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024021402-slit-duke-7761@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_selvaras@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=tern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox