Linux USB
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu
Subject: Re: [PATCH 1/2] usb: usb-acpi: Set port connect type of not connectable ports correctly
Date: Thu, 22 Feb 2024 15:06:53 +0100	[thread overview]
Message-ID: <2024022238-caddie-fanning-8ab5@gregkh> (raw)
In-Reply-To: <20240222133819.4149388-1-mathias.nyman@linux.intel.com>

On Thu, Feb 22, 2024 at 03:38:18PM +0200, Mathias Nyman wrote:
> Ports with  _UPC (USB Port Capability) ACPI objects stating they are
> "not connectable" are not wired to any connector or internal device.
> They only exist inside the host controller.
> 
> These ports may not have an ACPI _PLD (Physical Location of Device)
> object.
> 
> Rework the code so that _UPC is read even if _PLD does not exist, and
> make sure the port->connect_type is set to "USB_PORT_NOT_USED" instead
> of "USB_PORT_CONNECT_TYPE_UNKNOWN".
> 
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>

Does patch 2/2 need this?  If so, why isn't it marked for stable?

thanks,

greg k-h

  parent reply	other threads:[~2024-02-22 14:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 13:38 [PATCH 1/2] usb: usb-acpi: Set port connect type of not connectable ports correctly Mathias Nyman
2024-02-22 13:38 ` [PATCH 2/2] usb: port: Don't try to peer unused USB ports based on location Mathias Nyman
2024-02-22 14:06   ` Greg KH
2024-02-22 15:03     ` Mathias Nyman
2024-02-22 15:51   ` Paul Menzel
2024-02-22 14:06 ` Greg KH [this message]
2024-02-22 14:46   ` [PATCH 1/2] usb: usb-acpi: Set port connect type of not connectable ports correctly Mathias Nyman
2024-02-22 15:50     ` Greg KH
2024-02-22 16:25       ` Mathias Nyman
2024-02-22 22:43         ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024022238-caddie-fanning-8ab5@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox