public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Li Yang <leoyang.li@nxp.com>,
	linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	kernel@pengutronix.de
Subject: Re: [PATCH] usb: gadget: fsl-udc: Replace custom log wrappers by pr_{err,warn,debug}
Date: Mon, 4 Mar 2024 13:44:12 +0100	[thread overview]
Message-ID: <2024030429-oppressed-crispness-ac9d@gregkh> (raw)
In-Reply-To: <20240304121153.750165-2-u.kleine-koenig@pengutronix.de>

On Mon, Mar 04, 2024 at 01:11:53PM +0100, Uwe Kleine-König wrote:
> The custom log wrappers ERR, WARNING and DBG don't add anything useful
> that cannot easily be done with pr_err() and friends. Replace the custom
> stuff by the well known functions from printk.h.

These really should be dev_*() as there is a device structure buried
down in there somewhere :)

thanks,

greg k-h

      reply	other threads:[~2024-03-04 12:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 12:11 [PATCH] usb: gadget: fsl-udc: Replace custom log wrappers by pr_{err,warn,debug} Uwe Kleine-König
2024-03-04 12:44 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024030429-oppressed-crispness-ac9d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=leoyang.li@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox