* [PATCH] USB: serial: option: add Fibocom FM135-GL variants
@ 2024-03-06 8:20 bolan wang
0 siblings, 0 replies; 10+ messages in thread
From: bolan wang @ 2024-03-06 8:20 UTC (permalink / raw)
To: johan, gregkh, larsm17; +Cc: linux-usb, linux-kernel, bolan wang
Update the USB serial option driver support for the Fibocom
FM135-GL LTE modules.
- VID:PID 2cb7:0115, FM135-GL for laptop debug M.2 cards(with MBIM
interface for /Linux/Chrome OS)
0x0115: mbim, diag, at, pipe
Signed-off-by: bolan wang <bolan.wang@fibocom.com>
---
drivers/usb/serial/option.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 2ae124c49d44..ac637ba27313 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2267,6 +2267,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0xff, 0x30) }, /* Fibocom FG150 Diag */
{ USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0, 0) }, /* Fibocom FG150 AT */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0111, 0xff) }, /* Fibocom FM160 (MBIM mode) */
+ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0115, 0xff) }, /* Fibocom FM135 (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a0, 0xff) }, /* Fibocom NL668-AM/NL652-EU (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a2, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a3, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] USB: serial: option: add Fibocom FM135-GL variants
@ 2024-03-06 9:35 bolan wang
2024-03-06 10:05 ` Johan Hovold
0 siblings, 1 reply; 10+ messages in thread
From: bolan wang @ 2024-03-06 9:35 UTC (permalink / raw)
To: johan, gregkh, larsm17; +Cc: linux-usb, linux-kernel, bolan wang
Update the USB serial option driver support for the Fibocom
FM135-GL LTE modules.
- VID:PID 2cb7:0115, FM135-GL for laptop debug M.2 cards(with MBIM
interface for /Linux/Chrome OS)
0x0115: mbim, diag, at, pipe
Signed-off-by: bolan wang <bolan.wang@fibocom.com>
---
drivers/usb/serial/option.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 2ae124c49d44..c7ea7e5ec875 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2267,6 +2267,8 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0xff, 0x30) }, /* Fibocom FG150 Diag */
{ USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0, 0) }, /* Fibocom FG150 AT */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0111, 0xff) }, /* Fibocom FM160 (MBIM mode) */
+ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0115, 0xff), /* Fibocom FM135 (laptop MBIM) */
+ .driver_info = RSVD(5) },
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a0, 0xff) }, /* Fibocom NL668-AM/NL652-EU (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a2, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a3, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants
2024-03-06 9:35 bolan wang
@ 2024-03-06 10:05 ` Johan Hovold
0 siblings, 0 replies; 10+ messages in thread
From: Johan Hovold @ 2024-03-06 10:05 UTC (permalink / raw)
To: bolan wang; +Cc: gregkh, larsm17, linux-usb, linux-kernel
On Wed, Mar 06, 2024 at 05:35:33PM +0800, bolan wang wrote:
> Update the USB serial option driver support for the Fibocom
> FM135-GL LTE modules.
> - VID:PID 2cb7:0115, FM135-GL for laptop debug M.2 cards(with MBIM
> interface for /Linux/Chrome OS)
>
> 0x0115: mbim, diag, at, pipe
Please include the output of usb-devices for this device here in the
commit message.
> Signed-off-by: bolan wang <bolan.wang@fibocom.com>
> ---
Also, this is v3 of this patch and this needs to be indicated in the
patch summary ("PATCH v3") and by including a short changelog here after
the '---' line.
Please fix in a v4.
Johan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants
@ 2024-03-06 8:45 Bolan Wang(Bolan)
0 siblings, 0 replies; 10+ messages in thread
From: Bolan Wang(Bolan) @ 2024-03-06 8:45 UTC (permalink / raw)
To: Lars Melin, johan@kernel.org, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
> The option driver will bind because you have matched only on Class ff "{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a1, 0xff) }"
> There are other macros that you could possibly use but I can't tell you which since you have not shown an usb-device listing for the device.
> You can also blacklist an interface (RSV). The option driver source is full of examples of macro use and combinations.
Hi Lars:
The InterfaceNumber of the adb interface is 05, so the following code can blacklist an interface (RSV)? Is this appropriate for adb interface?
+ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0115, 0xff),
.driver_info = RSVD(5) }, /* Fibocom FM135 (laptop MBIM) */
thanks
bolan
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants
@ 2024-03-06 7:41 Bolan Wang(Bolan)
2024-03-06 8:29 ` Lars Melin
0 siblings, 1 reply; 10+ messages in thread
From: Bolan Wang(Bolan) @ 2024-03-06 7:41 UTC (permalink / raw)
To: Lars Melin, johan@kernel.org, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
> Hi Bolan,
> so you already know that other versions of the card will have the pid
> 0x01a1 and the serial interfaces will be of class ff but you don't know what those interfaces will be used for?
> You shall only add driver support for what you know today and not for something that might or might not be implemented in the future.
> For the device with pid 0x0115 you have listed an adb interface and adb interfaces should not be in the option driver.
Hi Lars:
Ok, I will remove 0x01a1 from option serial driver. And the adb listed in pid 0x0115 will also be removed.
Actually adb interface info with pid 0x0115 is: Class_ff&SubClass_42&Prot_01, the option driver will not bind it?
I will resubmit a new patch, please help review and abandon this.
thanks
bolan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants
2024-03-06 7:41 Bolan Wang(Bolan)
@ 2024-03-06 8:29 ` Lars Melin
0 siblings, 0 replies; 10+ messages in thread
From: Lars Melin @ 2024-03-06 8:29 UTC (permalink / raw)
To: Bolan Wang(Bolan), johan@kernel.org, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
On 2024-03-06 14:41, Bolan Wang(Bolan) wrote:
>> Hi Bolan,
>> so you already know that other versions of the card will have the pid
>> 0x01a1 and the serial interfaces will be of class ff but you don't know what those interfaces will be used for?
>> You shall only add driver support for what you know today and not for something that might or might not be implemented in the future.
>
>> For the device with pid 0x0115 you have listed an adb interface and adb interfaces should not be in the option driver.
>
> Hi Lars:
>
> Ok, I will remove 0x01a1 from option serial driver. And the adb listed in pid 0x0115 will also be removed.
> Actually adb interface info with pid 0x0115 is: Class_ff&SubClass_42&Prot_01, the option driver will not bind it?
> I will resubmit a new patch, please help review and abandon this.
>
> thanks
> bolan
>
>
The option driver will bind because you have matched only on Class ff
"{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a1, 0xff) }"
There are other macros that you could possibly use but I can't tell you
which since you have not shown an usb-device listing for the device.
You can also blacklist an interface (RSV). The option driver source is
full of examples of macro use and combinations.
thanks
Lars
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants
@ 2024-03-06 6:18 Bolan Wang(Bolan)
2024-03-06 6:39 ` Lars Melin
0 siblings, 1 reply; 10+ messages in thread
From: Bolan Wang(Bolan) @ 2024-03-06 6:18 UTC (permalink / raw)
To: Lars Melin, johan@kernel.org, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
> If the device with pid 0x01a1 only has an mbim interface as you have indicated then why do you add it to the option serial driver?
Hi Lars:
The pid 0x01a1 may include at, diag ports in different usb modes. Currently, only has the mbim interface.
thanks
bolan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants
2024-03-06 6:18 Bolan Wang(Bolan)
@ 2024-03-06 6:39 ` Lars Melin
0 siblings, 0 replies; 10+ messages in thread
From: Lars Melin @ 2024-03-06 6:39 UTC (permalink / raw)
To: Bolan Wang(Bolan), johan@kernel.org, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
On 2024-03-06 13:18, Bolan Wang(Bolan) wrote:
>> If the device with pid 0x01a1 only has an mbim interface as you have indicated then why do you add it to the option serial driver?
>
> Hi Lars:
> The pid 0x01a1 may include at, diag ports in different usb modes. Currently, only has the mbim interface.
>
> thanks
> bolan
Hi Bolan,
so you already know that other versions of the card will have the pid
0x01a1 and the serial interfaces will be of class ff but you don't
know what those interfaces will be used for?
You shall only add driver support for what you know today and not for
something that might or might not be implemented in the future.
For the device with pid 0x0115 you have listed an adb interface and adb
interfaces should not be in the option driver.
thanks
Lars
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] USB: serial: option: add Fibocom FM135-GL variants
@ 2024-03-06 2:13 bolan wang
2024-03-06 5:55 ` Lars Melin
0 siblings, 1 reply; 10+ messages in thread
From: bolan wang @ 2024-03-06 2:13 UTC (permalink / raw)
To: johan, gregkh; +Cc: linux-usb, linux-kernel, bolan wang
Update the USB serial option driver support for the Fibocom
FM135-GL
LTE modules as there are actually several different variants.
- VID:PID 2cb7:01a1, FM135-GL are laptop M.2 cards (with
MBIM interfaces for /Linux/Chrome OS)
- VID:PID 2cb7:0115, FM135-GL for laptop debug M.2 cards(with adb
interface for /Linux/Chrome OS)
0x01a1: mbim
0x0115: mbim, diag, at, pipe, adb
Signed-off-by: bolan wang <bolan.wang@fibocom.com>
---
drivers/usb/serial/option.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 2ae124c49d44..0981b8d8020c 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2267,7 +2267,9 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0xff, 0x30) }, /* Fibocom FG150 Diag */
{ USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0, 0) }, /* Fibocom FG150 AT */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0111, 0xff) }, /* Fibocom FM160 (MBIM mode) */
+ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0115, 0xff) }, /* Fibocom FM135 (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a0, 0xff) }, /* Fibocom NL668-AM/NL652-EU (laptop MBIM) */
+ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a1, 0xff) }, /* Fibocom FM135-GL (MBIM mode) */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a2, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a3, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a4, 0xff), /* Fibocom FM101-GL (laptop MBIM) */
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants
2024-03-06 2:13 bolan wang
@ 2024-03-06 5:55 ` Lars Melin
0 siblings, 0 replies; 10+ messages in thread
From: Lars Melin @ 2024-03-06 5:55 UTC (permalink / raw)
To: bolan wang, johan, gregkh; +Cc: linux-usb, linux-kernel
On 2024-03-06 09:13, bolan wang wrote:
> Update the USB serial option driver support for the Fibocom
> FM135-GL
> LTE modules as there are actually several different variants.
> - VID:PID 2cb7:01a1, FM135-GL are laptop M.2 cards (with
> MBIM interfaces for /Linux/Chrome OS)
> - VID:PID 2cb7:0115, FM135-GL for laptop debug M.2 cards(with adb
> interface for /Linux/Chrome OS)
>
> 0x01a1: mbim
> 0x0115: mbim, diag, at, pipe, adb
>
> Signed-off-by: bolan wang <bolan.wang@fibocom.com>
> ---
> drivers/usb/serial/option.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 2ae124c49d44..0981b8d8020c 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2267,7 +2267,9 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0xff, 0x30) }, /* Fibocom FG150 Diag */
> { USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0, 0) }, /* Fibocom FG150 AT */
> { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0111, 0xff) }, /* Fibocom FM160 (MBIM mode) */
> + { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0115, 0xff) }, /* Fibocom FM135 (laptop MBIM) */
> { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a0, 0xff) }, /* Fibocom NL668-AM/NL652-EU (laptop MBIM) */
> + { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a1, 0xff) }, /* Fibocom FM135-GL (MBIM mode) */
> { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a2, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */
> { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a3, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */
> { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a4, 0xff), /* Fibocom FM101-GL (laptop MBIM) */
If the device with pid 0x01a1 only has an mbim interface as you have
indicated then why do you add it to the option serial driver?
thanks
Lars
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-03-06 10:05 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-06 8:20 [PATCH] USB: serial: option: add Fibocom FM135-GL variants bolan wang
-- strict thread matches above, loose matches on Subject: below --
2024-03-06 9:35 bolan wang
2024-03-06 10:05 ` Johan Hovold
2024-03-06 8:45 Bolan Wang(Bolan)
2024-03-06 7:41 Bolan Wang(Bolan)
2024-03-06 8:29 ` Lars Melin
2024-03-06 6:18 Bolan Wang(Bolan)
2024-03-06 6:39 ` Lars Melin
2024-03-06 2:13 bolan wang
2024-03-06 5:55 ` Lars Melin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).