From: Greg KH <gregkh@linuxfoundation.org>
To: Dingyan Li <18500469033@163.com>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] USB: Use EHCI control transfer pid macros instead of constant values.
Date: Sat, 9 Mar 2024 07:14:48 +0000 [thread overview]
Message-ID: <2024030910-hurled-ibuprofen-1b52@gregkh> (raw)
In-Reply-To: <20240309033709.14604-1-18500469033@163.com>
On Sat, Mar 09, 2024 at 11:37:09AM +0800, Dingyan Li wrote:
> Macros with good names offer better readability. Besides, also move
> the definition to ehci.h.
>
> Signed-off-by: Dingyan Li <18500469033@163.com>
> Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
> ---
> V1 -> V2: Replacement in more places where Alan pointed out.
>
This should be v3, as you have added Alan's reviewed-by, and added the
proper versioning information. Please resend it as such as our tools
can't dig it out from the end of the thread like this :(
thanks,
greg k-h
next prev parent reply other threads:[~2024-03-09 7:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 17:31 [PATCH] USB: Use EHCI control transfer pid macros instead of constant values Dingyan Li
2024-03-07 18:42 ` Alan Stern
2024-03-08 1:08 ` [PATCH v2] " Dingyan Li
2024-03-08 7:55 ` Greg KH
2024-03-08 20:34 ` Alan Stern
2024-03-09 3:37 ` Dingyan Li
2024-03-09 7:14 ` Greg KH [this message]
2024-03-09 9:18 ` [PATCH v3] " Dingyan Li
2024-03-16 5:35 ` Re:Re: [PATCH v2] " Dingyan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024030910-hurled-ibuprofen-1b52@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=18500469033@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox