From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pavan Holla <pholla@chromium.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Subject: Re: [PATCH] usb: typec: ucsi: Wait 20ms before retrying reset
Date: Tue, 26 Mar 2024 09:29:27 +0100 [thread overview]
Message-ID: <2024032624-subtitle-crisped-f4f1@gregkh> (raw)
In-Reply-To: <20240325-ucsi-reset-delay-v1-1-d9e183e0f1e6@chromium.org>
On Mon, Mar 25, 2024 at 09:19:43PM +0000, Pavan Holla wrote:
> The PPM might take time to process reset. Allow 20ms for the reset to
> complete before issuing another reset.
>
> Signed-off-by: Pavan Holla <pholla@chromium.org>
What commit id does this fix? Does it need to go to older kernels?
> ---
> There is a 20ms delay for a reset retry to complete. However, the first
> reset attempt is expected to complete immediately after an async write
> of the reset command. This patch adds 20ms between the async write and
> the CCI read that expects the reset to be complete. The additional delay
> also allows the PPM to settle after the first reset, which seems to be
> the intention behind the original 20ms delay ( kernel v4.14 has a comment
> regarding the same )
Why was the comment removed in newer kernels?
Where does the magic 20ms number come from? What about systems that do
not need that time delay, did things just slow down for them?
thanks,
greg k-h
next prev parent reply other threads:[~2024-03-26 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 21:19 [PATCH] usb: typec: ucsi: Wait 20ms before retrying reset Pavan Holla
2024-03-26 8:29 ` Greg Kroah-Hartman [this message]
2024-03-26 23:34 ` Pavan Holla
2024-03-27 11:01 ` Heikki Krogerus
2024-03-27 23:12 ` Pavan Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032624-subtitle-crisped-f4f1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abhishekpandit@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pholla@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox