linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Surong Pang <surong.pang@unisoc.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Orson.Zhai@unisoc.com, Zhiyong.liu@unisoc.com,
	Surong.Pang@gmail.com
Subject: Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis
Date: Tue, 26 Mar 2024 10:36:12 +0100	[thread overview]
Message-ID: <2024032639-pope-tiling-340c@gregkh> (raw)
In-Reply-To: <20240306054949.324172-1-surong.pang@unisoc.com>

On Wed, Mar 06, 2024 at 01:49:49PM +0800, Surong Pang wrote:
> --- a/drivers/usb/gadget/function/rndis.c
> +++ b/drivers/usb/gadget/function/rndis.c
> @@ -39,6 +39,8 @@
>  
>  #include "rndis.h"
>  
> +static int max_out_pkts_per_xfer;
> +static int max_out_size_per_xfer;

Note, this will not work, you can't have device-specific variables as a
single entry, otherwise multiple devices at the same time will not work
at all.

thanks,

greg k-h

  parent reply	other threads:[~2024-03-26  9:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06  5:49 [PATCH] usb: gadget: rndis: add multi packages support for rndis Surong Pang
2024-03-26  9:34 ` Greg KH
2024-03-26  9:36 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-03-26 10:47 庞苏荣 (Surong Pang)
2024-03-26 14:07 ` Greg KH
2024-03-26 10:52 庞苏荣 (Surong Pang)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024032639-pope-tiling-340c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Orson.Zhai@unisoc.com \
    --cc=Surong.Pang@gmail.com \
    --cc=Zhiyong.liu@unisoc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=surong.pang@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).