Linux USB
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Allen Pais <apais@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org, tj@kernel.org,
	keescook@chromium.org, duncan.sands@free.fr,
	stern@rowland.harvard.edu, mathias.nyman@intel.com,
	oneukum@suse.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] USB: Convert from tasklet to BH workqueue
Date: Wed, 3 Apr 2024 16:57:39 +0200	[thread overview]
Message-ID: <2024040314-unbuckled-botanist-1afc@gregkh> (raw)
In-Reply-To: <20240403143852.13175-1-apais@linux.microsoft.com>

On Wed, Apr 03, 2024 at 02:38:52PM +0000, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves similarly to regular workqueues except that the queued work items
> are executed in the BH context.
> 
> This patch converts drivers/usb/* from tasklet to BH workqueue.
> 
> Based on the work done by Tejun Heo <tj@kernel.org>
> Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10
> 
> Changes in v2:
>  - Update code comments and commit message.
> 	Suggested by Greg K h
>  - Retain local variable name(hcd.c).
> 	Suggested by Alan Stern
> 
> Link to v1:https://lore.kernel.org/all/20240327160314.9982-1
> -apais@linux.microsoft.com/T/#m2ec7868fbf102f1551ebe4c92d200848b94af3b1

Why the line-wrap?

And v2 info should all go below the --- line, right?

v3 perhaps?

thanks,

greg k-h

  reply	other threads:[~2024-04-03 14:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 14:38 [PATCH v2] USB: Convert from tasklet to BH workqueue Allen Pais
2024-04-03 14:57 ` Greg KH [this message]
2024-04-03 15:40   ` Allen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024040314-unbuckled-botanist-1afc@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=apais@linux.microsoft.com \
    --cc=duncan.sands@free.fr \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=oneukum@suse.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox