public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Wulff <Chris.Wulff@biamp.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: f_uac1: Expose all string descriptors through configfs.
Date: Sun, 21 Apr 2024 12:16:22 +0200	[thread overview]
Message-ID: <2024042131-bonded-flaring-c579@gregkh> (raw)
In-Reply-To: <CO1PR17MB54198F836C3ED1B4FA5F14A9E10D2@CO1PR17MB5419.namprd17.prod.outlook.com>

On Fri, Apr 19, 2024 at 08:23:21PM +0000, Chris Wulff wrote:
> 
> This makes all string descriptors configurable for the UAC1 gadget
> so the user can configure names of terminals/controls/alt modes.
> 
> Signed-off-by: Chris Wulff <chris.wulff@biamp.com>
> ---
>  drivers/usb/gadget/function/f_uac1.c | 66 +++++++++++++++++++++-------
>  drivers/usb/gadget/function/u_uac1.h | 14 +++++-
>  2 files changed, 63 insertions(+), 17 deletions(-)

Any specific reason you didn't cc: the maintainer here?  Or the
developers who touched the file last?  scripts/get_maintainer.pl is your
friend :)

> 
> diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_uac1.c
> index 7de74a3dd392..100169d6dca7 100644
> --- a/drivers/usb/gadget/function/f_uac1.c
> +++ b/drivers/usb/gadget/function/f_uac1.c
> @@ -377,24 +377,10 @@ enum {
>  	STR_AS_OUT_IF_ALT1,
>  	STR_AS_IN_IF_ALT0,
>  	STR_AS_IN_IF_ALT1,
> +	NUM_STR_DESCRIPTORS,

Does this require a change to the Documentation/ABI/ files as well?

thanks,

greg k-h

  reply	other threads:[~2024-04-21 10:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 20:23 [PATCH] usb: gadget: f_uac1: Expose all string descriptors through configfs Chris Wulff
2024-04-21 10:16 ` Greg KH [this message]
2024-04-21 15:41   ` Chris Wulff
2024-04-22  4:53     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024042131-bonded-flaring-c579@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Chris.Wulff@biamp.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox