From: Greg KH <gregkh@linuxfoundation.org>
To: bugzilla-daemon@kernel.org
Cc: linux-usb@vger.kernel.org
Subject: Re: [Bug 218762] New: USB string order in dmesg
Date: Tue, 23 Apr 2024 13:31:18 +0200 [thread overview]
Message-ID: <2024042351-county-proven-e8a7@gregkh> (raw)
In-Reply-To: <bug-218762-208809@https.bugzilla.kernel.org/>
On Mon, Apr 22, 2024 at 07:34:17PM +0000, bugzilla-daemon@kernel.org wrote:
> Is there any good reason why the code
> https://github.com/torvalds/linux/blob/c85af715cac0a951eea97393378e84bb49384734/drivers/usb/core/hub.c#L2361
> is declaring string (show_string) values in a different order than they are
> specified in dev_info?
>
> dev_info(&udev->dev,
> "New USB device strings: Mfr=%d, Product=%d,
> SerialNumber=%d\n",
> udev->descriptor.iManufacturer,
> udev->descriptor.iProduct,
> udev->descriptor.iSerialNumber);
> show_string(udev, "Product", udev->product);
> show_string(udev, "Manufacturer", udev->manufacturer);
> show_string(udev, "SerialNumber", udev->serial);
>
>
> Now
> usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 4-1: Product: BM5100ADW series
> usb 4-1: Manufacturer: Pantum
> usb 4-1: SerialNumber: CK1A8823765
>
> Expected
> usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 4-1: Manufacturer: Pantum
> usb 4-1: Product: BM5100ADW series
> usb 4-1: SerialNumber: CK1A8823765
No specific reaason, just has always been that way for 20+ years and no
one has noticed.
next prev parent reply other threads:[~2024-04-23 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 19:34 [Bug 218762] New: USB string order in dmesg bugzilla-daemon
2024-04-23 11:31 ` Greg KH [this message]
2024-04-23 11:31 ` [Bug 218762] " bugzilla-daemon
2024-04-23 15:33 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024042351-county-proven-e8a7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bugzilla-daemon@kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).