From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
herve.codina@bootlin.com, christophercordahi@nanometrics.ca,
Bastien Curutchet <bastien.curutchet@bootlin.com>
Subject: [PATCH 4/4] usb: musb: da8xx: Implement BABBLE recovery
Date: Tue, 28 May 2024 12:20:26 +0200 [thread overview]
Message-ID: <20240528102026.40136-5-bastien.curutchet@bootlin.com> (raw)
In-Reply-To: <20240528102026.40136-1-bastien.curutchet@bootlin.com>
There is no specific behaviour implemented to recover from a babble
error. When a BABBLE error happens, recovery fails as connected sticks
are no longer detected by the USB controller.
Implement the recover callback of the MUSB operation to reset the USB
controller when a BABBLE happens.
Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
---
drivers/usb/musb/da8xx.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index c5cf733673a2..fcf06dcf2d61 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -220,6 +220,13 @@ static void __maybe_unused da8xx_musb_try_idle(struct musb *musb, unsigned long
mod_timer(&musb->dev_timer, timeout);
}
+static int da8xx_babble_recover(struct musb *musb)
+{
+ dev_dbg(musb->controller, "resetting controller to recover from babble\n");
+ musb_writel(musb->ctrl_base, DA8XX_USB_CTRL_REG, DA8XX_SOFT_RESET_MASK);
+ return 0;
+}
+
static irqreturn_t da8xx_musb_interrupt(int irq, void *hci)
{
struct musb *musb = hci;
@@ -480,6 +487,7 @@ static const struct musb_platform_ops da8xx_ops = {
#ifndef CONFIG_USB_MUSB_HOST
.try_idle = da8xx_musb_try_idle,
#endif
+ .recover = da8xx_babble_recover,
.set_vbus = da8xx_musb_set_vbus,
};
--
2.44.0
prev parent reply other threads:[~2024-05-28 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 10:20 [PATCH 0/4] usb: davinci: Add PM runtime support and improve HOST only mode support Bastien Curutchet
2024-05-28 10:20 ` [PATCH 1/4] phy: ti: phy-da8xx-usb: Add runtime PM support Bastien Curutchet
2024-06-15 12:09 ` Vinod Koul
2024-05-28 10:20 ` [PATCH 2/4] Revert "usb: musb: da8xx: Set phy in OTG mode by default" Bastien Curutchet
2024-05-28 10:20 ` [PATCH 3/4] usb: musb: da8xx: Remove try_idle implementation from host-only mode Bastien Curutchet
2024-05-28 10:20 ` Bastien Curutchet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528102026.40136-5-bastien.curutchet@bootlin.com \
--to=bastien.curutchet@bootlin.com \
--cc=b-liu@ti.com \
--cc=christophercordahi@nanometrics.ca \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox