From: Ferry Toth <ftoth@exalondelft.nl>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Ricardo B. Marliere" <ricardo@marliere.net>,
Kees Cook <kees@kernel.org>,
Linyu Yuan <quic_linyyuan@quicinc.com>,
Justin Stitt <justinstitt@google.com>,
Ferry Toth <ftoth@exalondelft.nl>,
Richard Acayan <mailingradian@gmail.com>,
Hardik Gajjar <hgajjar@de.adit-jv.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
s.hauer@pengutronix.de, jonathanh@nvidia.com,
paul@crapouillou.net, quic_eserrao@quicinc.com,
erosca@de.adit-jv.com, regressions@leemhuis.info,
Ferry Toth <fntoth@gmail.com>,
stable@vger.kernel.org
Subject: [PATCH v1 1/2] Revert "usb: gadget: u_ether: Re-attach netif device to mirror detachment"
Date: Thu, 6 Jun 2024 23:02:31 +0200 [thread overview]
Message-ID: <20240606210436.54100-2-ftoth@exalondelft.nl> (raw)
In-Reply-To: <20240606210436.54100-1-ftoth@exalondelft.nl>
This reverts commit 76c945730cdffb572c7767073cc6515fd3f646b4.
Prerequisite revert for the reverting of the original commit f49449fbc21e.
Fixes: 76c945730cdf ("usb: gadget: u_ether: Re-attach netif device to mirror detachment")
Fixes: f49449fbc21e ("usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach")
Reported-by: Ferry Toth <fntoth@gmail.com>
Cc: stable@vger.kernel.org
---
drivers/usb/gadget/function/u_ether.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 11dd0b9e847f..aa0511c3a62c 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -1163,8 +1163,6 @@ struct net_device *gether_connect(struct gether *link)
if (netif_running(dev->net))
eth_start(dev, GFP_ATOMIC);
- netif_device_attach(dev->net);
-
/* on error, disable any endpoints */
} else {
(void) usb_ep_disable(link->out_ep);
--
2.43.0
next prev parent reply other threads:[~2024-06-06 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 21:02 [PATCH v1 0/2] "usb: gadget: u_ether: revert netif_device_detach change Ferry Toth
2024-06-06 21:02 ` Ferry Toth [this message]
2024-06-20 17:35 ` [PATCH v1 1/2] Revert "usb: gadget: u_ether: Re-attach netif device to mirror detachment" Greg Kroah-Hartman
2024-06-20 19:00 ` Ferry Toth
2024-06-06 21:02 ` [PATCH v1 2/2] Revert "usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach" Ferry Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606210436.54100-2-ftoth@exalondelft.nl \
--to=ftoth@exalondelft.nl \
--cc=andriy.shevchenko@intel.com \
--cc=erosca@de.adit-jv.com \
--cc=fntoth@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hgajjar@de.adit-jv.com \
--cc=jonathanh@nvidia.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=paul@crapouillou.net \
--cc=quic_eserrao@quicinc.com \
--cc=quic_linyyuan@quicinc.com \
--cc=regressions@leemhuis.info \
--cc=ricardo@marliere.net \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox