public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: joswang <joswang1221@gmail.com>,
	Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Jos Wang <joswang@lenovo.com>
Subject: Re: [PATCH v4, 3/3] usb: dwc3: core: Workaround for CSR read timeout
Date: Wed, 12 Jun 2024 18:13:21 +0100	[thread overview]
Message-ID: <20240612-balmy-deviancy-7d68aca2173c@spud> (raw)
In-Reply-To: <2024061203-good-sneeze-f118@gregkh>

[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]

On Wed, Jun 12, 2024 at 07:04:28PM +0200, Greg KH wrote:
> On Wed, Jun 12, 2024 at 11:39:22PM +0800, joswang wrote:
> > From: Jos Wang <joswang@lenovo.com>
> > 
> > This is a workaround for STAR 4846132, which only affects
> > DWC_usb31 version2.00a operating in host mode.
> > 
> > There is a problem in DWC_usb31 version 2.00a operating
> > in host mode that would cause a CSR read timeout When CSR
> > read coincides with RAM Clock Gating Entry. By disable
> > Clock Gating, sacrificing power consumption for normal
> > operation.
> > 
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Jos Wang <joswang@lenovo.com>
> > ---
> > v1 -> v2:
> > - add "dt-bindings: usb: dwc3: Add snps,p2p3tranok quirk" patch,
> >   this patch does not make any changes
> > v2 -> v3:
> > - code refactor
> > - modify comment, add STAR number, workaround applied in host mode
> > - modify commit message, add STAR number, workaround applied in host mode
> > - modify Author Jos Wang
> > v3 -> v4:
> > - modify commit message, add Cc: stable@vger.kernel.org
> 
> This thread is crazy, look at:
> 	https://lore.kernel.org/all/20240612153922.2531-1-joswang1221@gmail.com/
> for how it looks.  How do I pick out the proper patches to review/apply
> there at all?  What would you do if you were in my position except just
> delete the whole thing?

I usually wouldn't admit to it, cos it means more for Rob or Krzysztof
to look at, but deleting the thread is exactly what I did for the
dt-binding part of it that I got sent.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-06-12 17:13 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-01  9:26 [PATCH 1/2] usb: dwc3: core: add p3p2tranok quirk joswang
2024-06-01  9:32 ` [PATCH 2/2] usb: dwc3: core: Workaround for CSR read timeout joswang
2024-06-03 13:00 ` [PATCH v2, 1/3] dt-bindings: usb: dwc3: Add snps,p2p3tranok quirk joswang
2024-06-04  6:33   ` Krzysztof Kozlowski
2024-06-12 14:28     ` joswang
2024-06-13  6:09       ` Krzysztof Kozlowski
2024-06-03 13:01 ` [PATCH v2, 2/3] usb: dwc3: core: add p3p2tranok quirk joswang
2024-06-04  0:02   ` Thinh Nguyen
2024-06-05  4:49     ` joswang
2024-06-07 14:24     ` joswang
2024-06-19 11:56     ` joswang
2024-06-22  0:05       ` Thinh Nguyen
2024-06-25 13:31         ` joswang
2024-06-26  1:29           ` Thinh Nguyen
2024-07-01 11:48             ` joswang
2024-06-03 13:02 ` [PATCH v2, 3/3] usb: dwc3: core: Workaround for CSR read timeout joswang
2024-06-04  0:07   ` Thinh Nguyen
2024-06-04 13:36     ` joswang
2024-06-04 23:13       ` Thinh Nguyen
2024-06-06  1:29       ` Thinh Nguyen
2024-06-07 14:07         ` joswang
2024-06-07 22:36           ` Thinh Nguyen
     [not found]         ` <CAMtoTm1roAvvWCu9LSfcbnozZnakMEexdUVxNyZ7N5KOG8tHcg@mail.gmail.com>
2024-06-07 22:49           ` Thinh Nguyen
2024-06-11 14:29 ` [PATCH v3, " joswang
2024-06-12  7:58   ` Greg KH
2024-06-12 12:44     ` joswang
2024-06-12 13:52     ` joswang
2024-06-12 14:07       ` Greg KH
2024-06-12 14:15         ` joswang
2024-06-12  7:58   ` Greg KH
2024-06-12 12:47     ` joswang
2024-06-12 12:56       ` Greg KH
2024-06-12 13:39         ` joswang
2024-06-12 13:52           ` Greg KH
2024-06-12 14:54 ` [PATCH v3, 1/3] dt-bindings: usb: dwc3: Add snps,p2p3tranok quirk joswang
2024-06-12 15:07 ` [PATCH v3, 2/3] usb: dwc3: core: add p3p2tranok quirk joswang
2024-06-12 15:23 ` [PATCH v4, 1/3] dt-bindings: usb: dwc3: Add snps,p2p3tranok quirk joswang
2024-06-13  6:17   ` Krzysztof Kozlowski
2024-06-13 13:19     ` joswang
2024-06-13 14:03       ` Krzysztof Kozlowski
2024-06-12 15:36 ` [PATCH v4, 2/3] usb: dwc3: core: add p3p2tranok quirk joswang
2024-06-12 15:39 ` [PATCH v4, 3/3] usb: dwc3: core: Workaround for CSR read timeout joswang
2024-06-12 17:04   ` Greg KH
2024-06-12 17:13     ` Conor Dooley [this message]
2024-06-13 11:46     ` joswang
2024-06-18  0:05       ` Thinh Nguyen
2024-06-18  4:24         ` Jung Daehwan
2024-06-18 21:36           ` Thinh Nguyen
2024-06-19  1:34             ` Jung Daehwan
2024-06-18 12:47         ` joswang
2024-06-18 13:38           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240612-balmy-deviancy-7d68aca2173c@spud \
    --to=conor@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joswang1221@gmail.com \
    --cc=joswang@lenovo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox