Re: [PATCH v2 1/2] scsi: core: Introduce the BLIST_SKIP_IO_HINTS flag

Martin K. Petersen
2024-06-13T19:40:51Z

Hi Bart!

> Prepare for skipping reading the IO hints VPD page for USB storage
^^^^^^^^^^^^^^^^^
[...]
> @@ -3117,6 +3118,9 @@ static void sd_read_io_hints(struct scsi_disk *sdkp, unsigned char *buffer)
> struct scsi_mode_data data;
> int res;
>
> + if (sdp->sdev_bflags & BLIST_SKIP_IO_HINTS)
> + return;
> +
> res = scsi_mode_sense(sdp, /*dbd=*/0x8, /*modepage=*/0x0a,
> /*subpage=*/0x05, buffer, SD_BUF_SIZE, SD_TIMEOUT,
> sdkp->max_retries, &data, &sshdr);
^^^^^^^^^^^^^^^

s/IO hints VPD page/IO Advice Hints Grouping mode page/g

?

PS. I'm not fussy about Cc. But I generally avoid listing anybody who
will be automatically copied by virtue of any *-by: tags.

I tend to use Cc as an indicator that this entity needs to act upon the
patch in question. Ack, review, test, respond to comments, or merge in
case of stable@.

If a person listed in Cc subsequently responds with a tag, their name
may be listed more than once in the commit description. But I view that
as documentation that the person whose feedback was requested actually
responded. That's useful information as far as I'm concerned...

--
Martin K. Petersen Oracle Linux Engineering