From: Mario Limonciello <mario.limonciello@amd.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
Daniel Drake <drake@endlessos.org>, Gary Li <Gary.Li@amd.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Mario Limonciello" <mario.limonciello@amd.com>
Subject: [PATCH 4/4] PCI: Drop Radeon quirk for Macbook Pro 8.2
Date: Thu, 13 Jun 2024 00:42:04 -0500 [thread overview]
Message-ID: <20240613054204.5850-5-mario.limonciello@amd.com> (raw)
In-Reply-To: <20240613054204.5850-1-mario.limonciello@amd.com>
commit 5938628c51a7 ("drm/radeon: make MacBook Pro d3_delay quirk more
generic") introduced a generic quirk for Macbook Pro 8.2s that contain
Radeon graphics to ensure that enough time had past when the device
was powered on.
As the PCI core now verifies the device is in D0 during power on this
extra artificial delay is no longer necessary.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/pci/quirks.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 942d0fe12cb1..19be953c9f37 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2038,14 +2038,6 @@ static void quirk_d3hot_delay(struct pci_dev *dev, unsigned int delay)
dev->d3hot_delay);
}
-static void quirk_radeon_pm(struct pci_dev *dev)
-{
- if (dev->subsystem_vendor == PCI_VENDOR_ID_APPLE &&
- dev->subsystem_device == 0x00e2)
- quirk_d3hot_delay(dev, 20);
-}
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x6741, quirk_radeon_pm);
-
/*
* NVIDIA Ampere-based HDA controllers can wedge the whole device if a bus
* reset is performed too soon after transition to D0, extend d3hot_delay
--
2.43.0
next prev parent reply other threads:[~2024-06-13 5:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 5:42 [PATCH 0/4] Verify devices transition from D3cold to D0 Mario Limonciello
2024-06-13 5:42 ` [PATCH 1/4] PCI: Check PCI_PM_CTRL in pci_dev_wait() Mario Limonciello
2024-06-19 18:33 ` Markus Elfring
2024-06-19 18:44 ` Mario Limonciello
2024-06-13 5:42 ` [PATCH 2/4] PCI: Verify functions currently in D3cold have entered D0 Mario Limonciello
2024-06-19 18:45 ` Markus Elfring
2024-06-19 18:46 ` Mario Limonciello
2024-06-13 5:42 ` [PATCH 3/4] PCI: Allow Ryzen XHCI controllers into D3cold and drop delays Mario Limonciello
2024-06-13 5:42 ` Mario Limonciello [this message]
2024-06-18 13:14 ` [PATCH 0/4] Verify devices transition from D3cold to D0 Mika Westerberg
2024-06-18 16:56 ` Mario Limonciello
2024-06-19 5:29 ` Mika Westerberg
2024-06-19 18:50 ` Mario Limonciello
2024-06-25 15:43 ` Mario Limonciello
2024-06-26 7:53 ` Mika Westerberg
2024-07-09 3:07 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613054204.5850-5-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Gary.Li@amd.com \
--cc=bhelgaas@google.com \
--cc=drake@endlessos.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox