From: Petko Manolov <petkan@nucleusys.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+5186630949e3c55f0799@syzkaller.appspotmail.com
Subject: Re: [PATCH net] net: usb: rtl8150 fix unintiatilzed variables in rtl8150_get_link_ksettings
Date: Wed, 19 Jun 2024 17:16:43 +0300 [thread overview]
Message-ID: <20240619141643.GB3770@bender.k.g> (raw)
In-Reply-To: <20240619132816.11526-1-oneukum@suse.com>
On 24-06-19 15:28:03, Oliver Neukum wrote:
> This functions retrieves values by passing a pointer. As the function that
> retrieves them can fail before touching the pointers, the variables must be
> initialized.
ACK.
Petko
> Reported-by: syzbot+5186630949e3c55f0799@syzkaller.appspotmail.com
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
> drivers/net/usb/rtl8150.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index 97afd7335d86..01a3b2417a54 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -778,7 +778,8 @@ static int rtl8150_get_link_ksettings(struct net_device *netdev,
> struct ethtool_link_ksettings *ecmd)
> {
> rtl8150_t *dev = netdev_priv(netdev);
> - short lpa, bmcr;
> + short lpa = 0;
> + short bmcr = 0;
> u32 supported;
>
> supported = (SUPPORTED_10baseT_Half |
> --
> 2.45.1
>
>
next prev parent reply other threads:[~2024-06-19 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 13:28 [PATCH net] net: usb: rtl8150 fix unintiatilzed variables in rtl8150_get_link_ksettings Oliver Neukum
2024-06-19 14:16 ` Petko Manolov [this message]
2024-06-20 14:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619141643.GB3770@bender.k.g \
--to=petkan@nucleusys.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=syzbot+5186630949e3c55f0799@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox