public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: joswang <joswang1221@gmail.com>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Jos Wang <joswang@lenovo.com>
Subject: Re: [PATCH v7] usb: dwc3: core: Workaround for CSR read timeout
Date: Fri, 21 Jun 2024 05:42:42 +0000	[thread overview]
Message-ID: <20240621054239.mskjqbuhovydvmu4@synopsys.com> (raw)
In-Reply-To: <2024062151-professor-squeak-a4a7@gregkh>

On Fri, Jun 21, 2024, Greg KH wrote:
> On Fri, Jun 21, 2024 at 09:40:10AM +0800, joswang wrote:
> > On Fri, Jun 21, 2024 at 1:16 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Wed, Jun 19, 2024 at 07:45:29PM +0800, joswang wrote:
> > > > From: Jos Wang <joswang@lenovo.com>
> > > >
> > > > This is a workaround for STAR 4846132, which only affects
> > > > DWC_usb31 version2.00a operating in host mode.
> > > >
> > > > There is a problem in DWC_usb31 version 2.00a operating
> > > > in host mode that would cause a CSR read timeout When CSR
> > > > read coincides with RAM Clock Gating Entry. By disable
> > > > Clock Gating, sacrificing power consumption for normal
> > > > operation.
> > > >
> > > > Cc: stable@vger.kernel.org
> > > > Signed-off-by: Jos Wang <joswang@lenovo.com>
> > >
> > > What commit id does this fix?  How far back should it be backported in
> > > the stable releases?
> > >
> > > thanks,
> > >
> > > greg k-h
> > 
> > Hello Greg Thinh
> > 
> > It seems first begin from the commit 1e43c86d84fb ("usb: dwc3: core:
> > Add DWC31 version 2.00a controller")
> > in 6.8.0-rc6 branch ?
> 
> That commit showed up in 6.9, not 6.8.  And if so, please resend with a
> proper "Fixes:" tag.
> 

This patch workarounds the controller's issue. It doesn't resolve any
particular commit that requires a "Fixes" tag. So, this should go on
"next". It can be backported as needed. If it's to be backported, it can
probably go back to as far as v4.3, to commit 690fb3718a70 ("usb: dwc3:
Support Synopsys USB 3.1 IP"). But you'd need to collect all the
dependencies including the commit mention above.

BR,
Thinh

  reply	other threads:[~2024-06-21  5:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19 11:45 [PATCH v7] usb: dwc3: core: Workaround for CSR read timeout joswang
2024-06-20 17:16 ` Greg KH
2024-06-21  1:40   ` joswang
2024-06-21  5:19     ` Greg KH
2024-06-21  5:42       ` Thinh Nguyen [this message]
2024-06-21  5:49         ` Greg KH
2024-06-21  6:20           ` Thinh Nguyen
2024-06-21  7:09             ` Greg KH
2024-06-21 23:09               ` Thinh Nguyen
2024-06-25 12:23                 ` joswang
2024-06-26  1:37                   ` Thinh Nguyen
2024-06-27 14:26                     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621054239.mskjqbuhovydvmu4@synopsys.com \
    --to=thinh.nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joswang1221@gmail.com \
    --cc=joswang@lenovo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox