Re: [PATCH 2/2] usb: chipidea: ci_hdrc_tegra: Switch to RUNTIME_PM_OPS()

Peter Chen
2024-07-10T01:52:06Z

On 24-06-25 20:10:23, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Replace SET_RUNTIME_PM_OPS() with its modern RUNTIME_PM_OPS()
> alternative.
>
> The combined usage of pm_ptr() and RUNTIME_PM_OPS allows the compiler
> to evaluate if the runtime suspend/resume() functions are used at build
> time or are simply dead code.
>
> This allows removing the __maybe_unused notation from the runtime
> suspend/resume() functions.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Acked-by: Peter Chen <peter.chen@kernel.org>

> ---
> drivers/usb/chipidea/ci_hdrc_tegra.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
> index 2cc305803217..9538d425f0a0 100644
> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> @@ -372,7 +372,7 @@ static void tegra_usb_remove(struct platform_device *pdev)
> pm_runtime_force_suspend(&pdev->dev);
> }
>
> -static int __maybe_unused tegra_usb_runtime_resume(struct device *dev)
> +static int tegra_usb_runtime_resume(struct device *dev)
> {
> struct tegra_usb *usb = dev_get_drvdata(dev);
> int err;
> @@ -386,7 +386,7 @@ static int __maybe_unused tegra_usb_runtime_resume(struct device *dev)
> return 0;
> }
>
> -static int __maybe_unused tegra_usb_runtime_suspend(struct device *dev)
> +static int tegra_usb_runtime_suspend(struct device *dev)
> {
> struct tegra_usb *usb = dev_get_drvdata(dev);
>
> @@ -396,15 +396,14 @@ static int __maybe_unused tegra_usb_runtime_suspend(struct device *dev)
> }
>
> static const struct dev_pm_ops tegra_usb_pm = {
> - SET_RUNTIME_PM_OPS(tegra_usb_runtime_suspend, tegra_usb_runtime_resume,
> - NULL)
> + RUNTIME_PM_OPS(tegra_usb_runtime_suspend, tegra_usb_runtime_resume, NULL)
> };
>
> static struct platform_driver tegra_usb_driver = {
> .driver = {
> .name = "tegra-usb",
> .of_match_table = tegra_usb_of_match,
> - .pm = &tegra_usb_pm,
> + .pm = pm_ptr(&tegra_usb_pm),
> },
> .probe = tegra_usb_probe,
> .remove_new = tegra_usb_remove,
> --
> 2.34.1
>