From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: 胡连勤 <hulianqin@vivo.com>
Cc: "laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"dan.scally@ideasonboard.com" <dan.scally@ideasonboard.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"opensource.kernel" <opensource.kernel@vivo.com>
Subject: Re: 答复: [PATCH v2] usb: gadget: uvc: Fixes the abnormal enumeration problem of mobile phone as UVC camera.
Date: Wed, 31 Jul 2024 13:54:10 +0200 [thread overview]
Message-ID: <2024073150-pointless-makeshift-3745@gregkh> (raw)
In-Reply-To: <TYUPR06MB62175899DECC7A9B0DA0DF01D2B12@TYUPR06MB6217.apcprd06.prod.outlook.com>
On Wed, Jul 31, 2024 at 11:49:11AM +0000, 胡连勤 wrote:
> When the phone is connected to the computer to use the webcam function,
> the phone needs to be enumerated as a uvc camera function.
>
> Because uvc->func.bind_deactivated is configured as true in the f_uvc
> driver uvc_alloc function, the usb_gadget_deactivate function is called
> during the execution of the configfs_composite_bind function to
> set gadget->deactivated to true, which in turn causes the
> usb_gadget_connect_locked function to fail to call the corresponding
> controller pullup operation (such as: dwc3_gadget_pullup,
> mtu3_gadget_pullup), and the USB cannot be enumerated
> normally under the uvc function combination.
>
> After applying this patch, we measured that under the uvc function,
> the dwc3 controller and the mtu3 controller can be enumerated normally,
> and the webcam function is normal.
>
> Fixes this by removing the setting of uvc->func.bind_deactivated to true.
>
> Signed-off-by: Lianqin Hu <hulianqin@vivo.com>
> ---
> v2:
> - Add "Fixes:" tag on the commit
There is no fixes tag here :(
Also you have a lot of trailing whitespace on the commit changelog, is
that intentional?
thanks,
greg k-h
next prev parent reply other threads:[~2024-07-31 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 11:49 答复: [PATCH v2] usb: gadget: uvc: Fixes the abnormal enumeration problem of mobile phone as UVC camera 胡连勤
2024-07-31 11:54 ` 胡连勤
2024-07-31 11:54 ` gregkh [this message]
2024-07-31 12:03 ` 答复: " 胡连勤
2024-07-31 12:24 ` gregkh
2024-07-31 12:23 ` Laurent Pinchart
[not found] ` <TYUPR06MB6217EF08BA3F758EB20C833DD2B12@TYUPR06MB6217.apcprd06.prod.outlook.com>
2024-07-31 12:54 ` Laurent Pinchart
2024-07-31 13:10 ` 答复: " 胡连勤
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024073150-pointless-makeshift-3745@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=dan.scally@ideasonboard.com \
--cc=hulianqin@vivo.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).