[PATCH] usb: core: sysfs: Unmerge @usb3_hardware_lpm_attr_group in remove_power_attributes()

Zijun Hu
2024-08-14T11:07:50Z

From: Zijun Hu <quic_zijuhu@quicinc.com>

Device attribute group @usb3_hardware_lpm_attr_group is merged by
add_power_attributes(), but it is not unmerged explicitly, fixed by
unmerging it in remove_power_attributes().

Fixes: 655fe4effe0f ("usbcore: add sysfs support to xHCI usb3 hardware LPM")
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
drivers/usb/core/sysfs.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c
index d83231d6736a..61b6d978892c 100644
--- a/drivers/usb/core/sysfs.c
+++ b/drivers/usb/core/sysfs.c
@@ -670,6 +670,7 @@ static int add_power_attributes(struct device *dev)

static void remove_power_attributes(struct device *dev)
{
+ sysfs_unmerge_group(&dev->kobj, &usb3_hardware_lpm_attr_group);
sysfs_unmerge_group(&dev->kobj, &usb2_hardware_lpm_attr_group);
sysfs_unmerge_group(&dev->kobj, &power_attr_group);
}

---
base-commit: 82313624b2ae5a943d16475a566b65c873989e9f
change-id: 20240814-sysfs_fix-2206de9b0179

Best regards,
--
Zijun Hu <quic_zijuhu@quicinc.com>