Re: [PATCH] usb: core: sysfs: Unmerge @usb3_hardware_lpm_attr_group in remove_power_attributes()

Greg Kroah-Hartman
2024-08-14T11:47:48Z

On Wed, Aug 14, 2024 at 07:07:34PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> Device attribute group @usb3_hardware_lpm_attr_group is merged by
> add_power_attributes(), but it is not unmerged explicitly, fixed by
> unmerging it in remove_power_attributes().
>
> Fixes: 655fe4effe0f ("usbcore: add sysfs support to xHCI usb3 hardware LPM")
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
> drivers/usb/core/sysfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c
> index d83231d6736a..61b6d978892c 100644
> --- a/drivers/usb/core/sysfs.c
> +++ b/drivers/usb/core/sysfs.c
> @@ -670,6 +670,7 @@ static int add_power_attributes(struct device *dev)
>
> static void remove_power_attributes(struct device *dev)
> {
> + sysfs_unmerge_group(&dev->kobj, &usb3_hardware_lpm_attr_group);
> sysfs_unmerge_group(&dev->kobj, &usb2_hardware_lpm_attr_group);
> sysfs_unmerge_group(&dev->kobj, &power_attr_group);
> }
>
> ---
> base-commit: 82313624b2ae5a943d16475a566b65c873989e9f
> change-id: 20240814-sysfs_fix-2206de9b0179
>
> Best regards,
> --
> Zijun Hu <quic_zijuhu@quicinc.com>
>
>

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
older released kernel, yet you do not have a cc: stable line in the
signed-off-by area at all, which means that the patch will not be
applied to any older kernel releases. To properly fix this, please
follow the documented rules in the
Documentation/process/stable-kernel-rules.rst file for how to resolve
this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot