Linux USB
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Selvarasu Ganesan <selvarasu.g@samsung.com>
Cc: Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, jh0801.jung@samsung.com,
	dh10.jung@samsung.com, naushad@samsung.com, akash.m5@samsung.com,
	rc93.raju@samsung.com, taehyun.cho@samsung.com,
	hongpooh.kim@samsung.com, eomji.oh@samsung.com,
	shijie.cai@samsung.com, stable@vger.kernel.org
Subject: Re: [PATCH v3] usb: dwc3: core: Prevent USB core invalid event buffer address access
Date: Sat, 17 Aug 2024 07:17:53 +0200	[thread overview]
Message-ID: <2024081700-skittle-lethargy-9567@gregkh> (raw)
In-Reply-To: <4f286780-89a2-496d-9007-d35559f26a21@samsung.com>

On Fri, Aug 16, 2024 at 09:13:09PM +0530, Selvarasu Ganesan wrote:
> 
> On 8/16/2024 3:25 PM, Greg KH wrote:
> > On Thu, Aug 15, 2024 at 12:18:31PM +0530, Selvarasu Ganesan wrote:
> >> This commit addresses an issue where the USB core could access an
> >> invalid event buffer address during runtime suspend, potentially causing
> >> SMMU faults and other memory issues in Exynos platforms. The problem
> >> arises from the following sequence.
> >>          1. In dwc3_gadget_suspend, there is a chance of a timeout when
> >>          moving the USB core to the halt state after clearing the
> >>          run/stop bit by software.
> >>          2. In dwc3_core_exit, the event buffer is cleared regardless of
> >>          the USB core's status, which may lead to an SMMU faults and
> >>          other memory issues. if the USB core tries to access the event
> >>          buffer address.
> >>
> >> To prevent this hardware quirk on Exynos platforms, this commit ensures
> >> that the event buffer address is not cleared by software  when the USB
> >> core is active during runtime suspend by checking its status before
> >> clearing the buffer address.
> >>
> >> Cc: stable@vger.kernel.org # v6.1+
> > Any hint as to what commit id this fixes?
> >
> > thanks,
> >
> > greg k-h
> 
> 
> Hi Greg,
> 
> This issue is not related to any particular commit. The given fix is 
> address a hardware quirk on the Exynos platform. And we require it to be 
> backported on stable kernel 6.1 and above all stable kernel.

If it's a hardware quirk issue, why are you restricting it to a specific
kernel release and not a specific kernel commit?  Why not 5.15?  5.4?

thanks,

greg k-h

  reply	other threads:[~2024-08-17  5:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240815064918epcas5p1248e4f9084d33fdb11a25fa34e66cdbe@epcas5p1.samsung.com>
2024-08-15  6:48 ` [PATCH v3] usb: dwc3: core: Prevent USB core invalid event buffer address access Selvarasu Ganesan
2024-08-16  9:55   ` Greg KH
2024-08-16 15:43     ` Selvarasu Ganesan
2024-08-17  5:17       ` Greg KH [this message]
2024-08-17 13:43         ` Selvarasu Ganesan
2024-08-21  5:29           ` Selvarasu Ganesan
2024-08-22  7:59           ` Greg KH
2024-08-28  4:08             ` Selvarasu Ganesan
2024-08-16 22:31   ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024081700-skittle-lethargy-9567@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=akash.m5@samsung.com \
    --cc=dh10.jung@samsung.com \
    --cc=eomji.oh@samsung.com \
    --cc=hongpooh.kim@samsung.com \
    --cc=jh0801.jung@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=naushad@samsung.com \
    --cc=rc93.raju@samsung.com \
    --cc=selvarasu.g@samsung.com \
    --cc=shijie.cai@samsung.com \
    --cc=stable@vger.kernel.org \
    --cc=taehyun.cho@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox