From: kernel test robot <lkp@intel.com>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [usb:usb-testing 20/25] drivers/usb/misc/onboard_usb_dev.c:329:15: error: implicit declaration of function 'i2c_smbus_write_block_data'
Date: Sat, 24 Aug 2024 22:53:53 +0800 [thread overview]
Message-ID: <202408242231.WOLALxi9-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
head: 9a03b9a88e4a44e358e3638736286442ae262497
commit: 7b5e970ff0e58f9239226fe81c77d5b98d744986 [20/25] usb: misc: onboard_usb_dev: add Microchip usb5744 SMBus programming support
config: arc-randconfig-001-20240824 (https://download.01.org/0day-ci/archive/20240824/202408242231.WOLALxi9-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240824/202408242231.WOLALxi9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408242231.WOLALxi9-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/usb/misc/onboard_usb_dev.c: In function 'onboard_dev_5744_i2c_init':
>> drivers/usb/misc/onboard_usb_dev.c:329:15: error: implicit declaration of function 'i2c_smbus_write_block_data' [-Werror=implicit-function-declaration]
329 | ret = i2c_smbus_write_block_data(client, 0, sizeof(wr_buf), wr_buf);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/usb/misc/onboard_usb_dev.c:333:15: error: implicit declaration of function 'i2c_smbus_write_word_data' [-Werror=implicit-function-declaration]
333 | ret = i2c_smbus_write_word_data(client, USB5744_CMD_CREG_ACCESS,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/i2c_smbus_write_block_data +329 drivers/usb/misc/onboard_usb_dev.c
311
312 static int onboard_dev_5744_i2c_init(struct i2c_client *client)
313 {
314 struct device *dev = &client->dev;
315 int ret;
316
317 /*
318 * Set BYPASS_UDC_SUSPEND bit to ensure MCU is always enabled
319 * and ready to respond to SMBus runtime commands.
320 * The command writes 5 bytes to memory and single data byte in
321 * configuration register.
322 */
323 char wr_buf[7] = {USB5744_CREG_MEM_ADDR, 5,
324 USB5744_CREG_WRITE, 1,
325 USB5744_CREG_RUNTIMEFLAGS2,
326 USB5744_CREG_RUNTIMEFLAGS2_LSB,
327 USB5744_CREG_BYPASS_UDC_SUSPEND};
328
> 329 ret = i2c_smbus_write_block_data(client, 0, sizeof(wr_buf), wr_buf);
330 if (ret)
331 return dev_err_probe(dev, ret, "BYPASS_UDC_SUSPEND bit configuration failed\n");
332
> 333 ret = i2c_smbus_write_word_data(client, USB5744_CMD_CREG_ACCESS,
334 USB5744_CMD_CREG_ACCESS_LSB);
335 if (ret)
336 return dev_err_probe(dev, ret, "Configuration Register Access Command failed\n");
337
338 /* Send SMBus command to boot hub. */
339 ret = i2c_smbus_write_word_data(client, USB5744_CMD_ATTACH,
340 USB5744_CMD_ATTACH_LSB);
341 if (ret < 0)
342 return dev_err_probe(dev, ret, "USB Attach with SMBus command failed\n");
343
344 return ret;
345 }
346
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-08-24 14:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 14:53 kernel test robot [this message]
2024-08-25 11:45 ` [usb:usb-testing 20/25] drivers/usb/misc/onboard_usb_dev.c:329:15: error: implicit declaration of function 'i2c_smbus_write_block_data' Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408242231.WOLALxi9-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=radhey.shyam.pandey@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox