* [PATCH v3] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium xHCI host
@ 2024-08-30 4:35 WangYuli
2024-08-30 5:23 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: WangYuli @ 2024-08-30 4:35 UTC (permalink / raw)
To: mathias.nyman, gregkh, sergei.shtylyov, helgaas, yuzenghui
Cc: linux-usb, linux-kernel, linux-pci, guanwentao, WangYuli,
Chen Baozi, Wang Zhimin, Chen Zhenhua, Wang Yinfeng, Jiakun Shuai
The resume operation of Phytium Px210 xHCI host would failed
to restore state. Use the XHCI_RESET_ON_RESUME quirk to skip
it and reset the controller after resume.
Changlog:
*v1 -> v2: Move the PCI_VENDOR_ID_PHYTIUM form pci_ids.h to xhci-pci.c
v2 -> v3: Change "||" to "&&", that was a mistake.
Co-developed-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Co-developed-by: Wang Zhimin <wangzhimin1179@phytium.com.cn>
Signed-off-by: Wang Zhimin <wangzhimin1179@phytium.com.cn>
Co-developed-by: Chen Zhenhua <chenzhenhua@phytium.com.cn>
Signed-off-by: Chen Zhenhua <chenzhenhua@phytium.com.cn>
Co-developed-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Co-developed-by: Jiakun Shuai <shuaijiakun1288@phytium.com.cn>
Signed-off-by: Jiakun Shuai <shuaijiakun1288@phytium.com.cn>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
drivers/usb/host/xhci-pci.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index b5705ed01d83..bfb8f0699475 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -55,6 +55,9 @@
#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI 0x51ed
#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI 0x54ed
+#define PCI_VENDOR_ID_PHYTIUM 0x1db7
+#define PCI_DEVICE_ID_PHYTIUM_XHCI 0xdc27
+
/* Thunderbolt */
#define PCI_DEVICE_ID_INTEL_MAPLE_RIDGE_XHCI 0x1138
#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_XHCI 0x15b5
@@ -407,6 +410,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
if (pdev->vendor == PCI_VENDOR_ID_VIA)
xhci->quirks |= XHCI_RESET_ON_RESUME;
+ if (pdev->vendor == PCI_VENDOR_ID_PHYTIUM &&
+ pdev->device == PCI_DEVICE_ID_PHYTIUM_XHCI)
+ xhci->quirks |= XHCI_RESET_ON_RESUME;
+
/* See https://bugzilla.kernel.org/show_bug.cgi?id=79511 */
if (pdev->vendor == PCI_VENDOR_ID_VIA &&
pdev->device == 0x3432)
--
2.43.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium xHCI host
2024-08-30 4:35 [PATCH v3] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium xHCI host WangYuli
@ 2024-08-30 5:23 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2024-08-30 5:23 UTC (permalink / raw)
To: WangYuli
Cc: mathias.nyman, sergei.shtylyov, helgaas, yuzenghui, linux-usb,
linux-kernel, linux-pci, guanwentao, Chen Baozi, Wang Zhimin,
Chen Zhenhua, Wang Yinfeng, Jiakun Shuai
On Fri, Aug 30, 2024 at 12:35:09PM +0800, WangYuli wrote:
> The resume operation of Phytium Px210 xHCI host would failed
> to restore state. Use the XHCI_RESET_ON_RESUME quirk to skip
> it and reset the controller after resume.
>
> Changlog:
> *v1 -> v2: Move the PCI_VENDOR_ID_PHYTIUM form pci_ids.h to xhci-pci.c
> v2 -> v3: Change "||" to "&&", that was a mistake.
As per the documentation, the changelog goes below the --- line.
Please fix up and send a v4.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-30 5:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-30 4:35 [PATCH v3] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium xHCI host WangYuli
2024-08-30 5:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).