From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEF7B1D551; Thu, 5 Sep 2024 14:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725546375; cv=none; b=PLg919CVBPbRbZqbQqNAVD2pzb9YV3OZhyQLmRlEvi49bSLx54DM3KK5nPKjym+3uLQ6jCPsl5uAiMyvLsmcMhUPCkD+naSmv40MMwhwigRYL9PVCzNSBcNbJ8g57il8DwSMOULIrDxQcST9X9HOixOxNbp3f14fWIkr3q6+DdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725546375; c=relaxed/simple; bh=mQD2mFfNuZhHKI/T+P7yQlscPdXQiqObJ1h4qf2fLO4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e2kESbe68JrRAEI5I6C367qTkrusW+VuvdtT5y7ue6eKFidQm9RZ9DIWfkxV0npFsw02BGHQawAyoKIxO25r2bIDunnqj/sc9kAsm7XLbpa5OUbAo04JpzLv6LTO9CAhZvG2XVYOI1Fmhp6gK47Cf6J/jscYf6NM3X0VYEsP1GQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=iXl7jMKh; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="iXl7jMKh" Received: from francesco-nb (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id BAAAE1F9E3; Thu, 5 Sep 2024 16:25:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1725546360; bh=0zf2HoKYznFnphkWJAchIZMm+w2OxCvnYqzP6Cz+V+c=; h=From:To:Subject; b=iXl7jMKhgJxHRrEeIfX4vCFRRDQ/vkO/ExDPxPjNHnJQVr1zdQ95rg3IANHEn8Hz7 e3prQ4J0b1h/8u63AI72R/2K8broI6qkDXt3uIiNxtvi2lZTsLx52lc5FybMXi9Tn7 eDTZNPBmYAqqoleAZK9HksM2mghr9wqmvtu7/k2J2Yn3KXWx9eqF2bx81w0Xi9SVra KXkjry3GVT5ynQjPDhUnOnnHGU8LRE8197IaivmugeUsvgLaFK3w+WlFbAM1dO749c 4+95ao9XjaBzoyb6ePk1Fb8hOU/kq6nKqFmDdTR2RrshUYopQAfAh9c1FFJN84nFeD 8g+iSn7sp9dSw== Date: Thu, 5 Sep 2024 16:25:54 +0200 From: Francesco Dolcini To: Parth Pancholi Cc: Heikki Krogerus , Greg Kroah-Hartman , Emanuele Ghidoli , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Parth Pancholi Subject: Re: [PATCH v2] usb: typec: tcpci: support edge irq Message-ID: <20240905142554.GA40671@francesco-nb> References: <20240905065328.7116-1-parth105105@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240905065328.7116-1-parth105105@gmail.com> On Thu, Sep 05, 2024 at 08:53:28AM +0200, Parth Pancholi wrote: > From: Emanuele Ghidoli > > TCPCI USB PHY - PTN5110 could be used with SOCs that only support > the edge-triggered GPIO interrupts such as TI's K3 device AM69. > Move the interrupt configuration to the firmware which would > allow to accommodate edge triggered interrupts for such SOCs. > In order to support the edge interrupts, register irq line in advance > and keep track of occurrence during port registering. > > When the edge interrupts are used, it is observed that some of the > interrupts are missed when tcpci_irq() is serving the current > interrupt. Therefore, check the status register at the end of > tcpci_irq() and re-run the function if the status is not clear > i.e. pending interrupt. > > Signed-off-by: Emanuele Ghidoli > Signed-off-by: Parth Pancholi Reviewed-by: Francesco Dolcini