From: "Michał Pecio" <michal.pecio@gmail.com>
To: ki.chiang65@gmail.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, mathias.nyman@intel.com
Subject: Re: [PATCH 0/3] xhci: Some improvement for Etron xHCI host
Date: Wed, 11 Sep 2024 09:38:28 +0200 [thread overview]
Message-ID: <20240911093828.58129593@foxbook> (raw)
In-Reply-To: <20240911051716.6572-4-ki.chiang65@gmail.com>
Hi,
I have some Etron controller (forgot which one) but I'm not using it
because it crashes ("dies") all the time under my workloads.
I suppose I could try your patches if I find a moment for it.
I'm aware of one more bug which affects my Etron: if an error occurs
on an isochronous TD, two events are generated: first the error, then
"success", even if the error is on the final TRB (the common case).
Then the "success" causes "TRB DMA not part of current TD" warning.
I suspect that all Etron chips are the same. This should be easily
reproducible by unpligging an audio/video device while streaming.
Considering how utterly broken this hardware is, I think it could be
more efficient to have a single "Etron host" quirk. These bugs are
so stupid that it seems unlikely that any of Etron quirks would ever
be reused on other hardware. Of course it should still use "general"
quirks when applicable, such as "broken streams", which it does IIRC.
Regards,
Michal
next prev parent reply other threads:[~2024-09-11 7:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 5:17 [PATCH 3/3] xhci: Don't perform Soft Retry for Etron xHCI host Kuangyi Chiang
2024-09-11 5:17 ` [PATCH 2/3] xhci: Fix control transfer error on " Kuangyi Chiang
2024-09-11 7:52 ` Michał Pecio
2024-09-11 15:09 ` Mathias Nyman
2024-09-12 6:19 ` Kuangyi Chiang
2024-09-11 15:07 ` Mathias Nyman
2024-09-13 5:25 ` Kuangyi Chiang
2024-09-11 5:17 ` [PATCH 1/3] xhci: Don't issue Reset Device command to " Kuangyi Chiang
2024-09-11 5:17 ` [PATCH 0/3] xhci: Some improvement for " Kuangyi Chiang
2024-09-11 7:38 ` Michał Pecio [this message]
2024-09-12 5:52 ` Kuangyi Chiang
2024-09-12 7:12 ` Michał Pecio
2024-09-16 2:04 ` Kuangyi Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911093828.58129593@foxbook \
--to=michal.pecio@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ki.chiang65@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).