public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Xu Yang <xu.yang_2@nxp.com>
To: peter.chen@kernel.org, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, imx@lists.linux.dev, jun.li@nxp.com
Subject: [PATCH 1/3] usb: chipidea: udc: handle USB Error Interrupt if IOC not set
Date: Thu, 12 Sep 2024 11:35:49 +0800	[thread overview]
Message-ID: <20240912033551.910337-1-xu.yang_2@nxp.com> (raw)

As per USBSTS register description about UEI:

  When completion of a USB transaction results in an error condition, this
  bit is set by the Host/Device Controller. This bit is set along with the
  USBINT bit, if the TD on which the error interrupt occurred also had its
  interrupt on complete (IOC) bit set.

Currently, device controller will do nothing when endpoints met transfer
error if IOC didn't set on that error dTD since UI didn't assert too. This
will also handle UEI event as same as USBSTS.UI for such cases.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
 drivers/usb/chipidea/udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 69ef3cd8d4f8..b9ccf62e0a50 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -2063,7 +2063,7 @@ static irqreturn_t udc_irq(struct ci_hdrc *ci)
 			}
 		}
 
-		if (USBi_UI  & intr)
+		if ((USBi_UI | USBi_UEI) & intr)
 			isr_tr_complete_handler(ci);
 
 		if ((USBi_SLI & intr) && !(ci->suspended)) {
-- 
2.34.1


             reply	other threads:[~2024-09-12  3:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12  3:35 Xu Yang [this message]
2024-09-12  3:35 ` [PATCH 2/3] usb: chipidea: udc: improve dTD link logic Xu Yang
2024-09-12  4:54   ` Frank Li
2024-09-13  1:52     ` Xu Yang
2024-09-13  8:51   ` kernel test robot
2024-09-12  3:35 ` [PATCH 3/3] usb: chipidea: udc: make isoc endpoint a bit error tolerant Xu Yang
2024-09-12  5:13   ` Frank Li
2024-09-13  1:55     ` Xu Yang
2024-09-13  1:49   ` Peter Chen
2024-09-13  3:12     ` Xu Yang
2024-09-12  5:26 ` [PATCH 1/3] usb: chipidea: udc: handle USB Error Interrupt if IOC not set Frank Li
2024-09-13  3:21   ` Xu Yang
2024-09-13  1:37 ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240912033551.910337-1-xu.yang_2@nxp.com \
    --to=xu.yang_2@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=jun.li@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox