From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC74D5C613; Tue, 17 Sep 2024 07:08:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726556905; cv=none; b=tqzgaM4KDVGNJGWQzsam3rikBYO9ZNGo5Cz5umV5y8WcnJ1lXxQRWdtd3puFeJD/xCsHF/l1gmDzDps7xJOUhiMUE+MiRYjme1h2N+5koLO2jb4yhAJ82knImgEqdfbRLC5lHSivsRktp4MQ6e0OMHylhyHRWwm41MfSe0ozonQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726556905; c=relaxed/simple; bh=ywDWDT7uwRjpjVeQCDAYEXrWBlGwwNQFLzAouXZ5Fp8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qqq3wpSkd1q+72ZUdBPPYiFJ7db5Z8W0NLI1czI1cMoFIMA4rRA0yyW1uJ2H8WzHsm9GciW9Z+slIbhwW8z29YGKYdiJyFHoGqJf88tXxuY9d6I621fZ5Ce6FO0U6KxzRLKPxwbStCGnvzk2ZjLn3P/1UHgQ7AitTcLvcJlAXVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pi/MiEDF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pi/MiEDF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF951C4CECE; Tue, 17 Sep 2024 07:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1726556904; bh=ywDWDT7uwRjpjVeQCDAYEXrWBlGwwNQFLzAouXZ5Fp8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pi/MiEDFtexiTTgZTDadyhzzx9yFK3hhOqM7BfcZlxJ26q/uLRKBok9H9C9qESr3v H5ajlgnvcMcHZfGn1O/daOMxiV0ixBxf4RuTpR3VB2gtU4YYWxAITapWxgy3SVBZeU YtAL5EeIutyqNbEyrTL2L7KCwzq4ekoYhjfE1HJM= Date: Tue, 17 Sep 2024 09:08:20 +0200 From: "gregkh@linuxfoundation.org" To: Thinh Nguyen Cc: Selvarasu Ganesan , "felipe.balbi@linux.intel.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jh0801.jung@samsung.com" , "dh10.jung@samsung.com" , "naushad@samsung.com" , "akash.m5@samsung.com" , "rc93.raju@samsung.com" , "taehyun.cho@samsung.com" , "hongpooh.kim@samsung.com" , "eomji.oh@samsung.com" , "shijie.cai@samsung.com" , stable Subject: Re: [PATCH v2] usb: dwc3: core: Stop processing of pending events if controller is halted Message-ID: <2024091758-devotion-clutter-29f6@gregkh> References: <20240916224543.187-1-selvarasu.g@samsung.com> <20240916230032.ugw23x7gijamrf5x@synopsys.com> <2024091716-snide-mashing-2c21@gregkh> <20240917054703.w47rfo7x4lhzgccn@synopsys.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240917054703.w47rfo7x4lhzgccn@synopsys.com> On Tue, Sep 17, 2024 at 05:47:05AM +0000, Thinh Nguyen wrote: > On Tue, Sep 17, 2024, gregkh@linuxfoundation.org wrote: > > On Mon, Sep 16, 2024 at 11:00:30PM +0000, Thinh Nguyen wrote: > > > On Tue, Sep 17, 2024, Selvarasu Ganesan wrote: > > > > This commit addresses an issue where events were being processed when > > > > the controller was in a halted state. To fix this issue by stop > > > > processing the events as the event count was considered stale or > > > > invalid when the controller was halted. > > > > > > > > Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM") > > > > Cc: stable > > > > > > Checkpatch doesn't like that format. Fix the Cc stable tag to below: > > > > > > Cc: stable@kernel.org > > > > What? Why? That should be fine, exactly what is the warning that this > > gives? That should be fine, as it's what my scripts put into patches > > that I create :) > > > > This is what checkpatch complains: > > WARNING:BAD_STABLE_ADDRESS_STYLE: Invalid email format for stable: 'stable ', prefer 'stable@kernel.org' > #23: > Cc: stable > > total: 0 errors, 1 warnings, 0 checks, 72 lines checked Ugh, that's wrong, whatever you want to do here is fine. Someone should send a patch for checkpatch... thanks, greg k-h