From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D10FF142E9F for ; Tue, 24 Sep 2024 07:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727162687; cv=none; b=o+dx6tpSMP5dHUgU4Q0lw5x02iIgV4pwA9GUcR/Yh0NhrJZyE08NkDetsDJPAtL38SjW1iEINPWosZ61k1rilEcAKjlVqw1sU6xy7wlamv5pFtVOmJlsUlvhJZ/OTQLQsC4Ah+CoIxgtdaJXbU38aNtQBGcZDi490OB4x7QHu3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727162687; c=relaxed/simple; bh=d15sbK686HNNoIYxHbjwubLOhx1YnkTojjBqukM43D8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QyDqbot06MbNnQdkqBd+UvCRZv6hOgutuG41ZiOzlJUt0t51upzozKcnlgb3qek5Dxej2jvD5rPZ5ycwCRD97UYvhWTiptaG7msL2Qkae6Tjkfilal3k1YjwlGGZdcvMHt/P6eOoi5GBMw14uSwdMGErRlzaCSGZauzkdfJIJxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sszuX-0001bn-U3; Tue, 24 Sep 2024 09:24:37 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sszuW-0018ph-Vd; Tue, 24 Sep 2024 09:24:36 +0200 Received: from mfe by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sszuW-009Mh0-2n; Tue, 24 Sep 2024 09:24:36 +0200 Date: Tue, 24 Sep 2024 09:24:36 +0200 From: Marco Felsch To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Shawn Guo , Petr Benes , devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Michael Walle , imx@lists.linux.dev, Alexander Stein , Sascha Hauer , Mathieu Othacehe , Hugo Villeneuve , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Hiago De Franco , Herburger , Pengutronix Kernel Team , Joao Paulo Goncalves , Fabio Estevam , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/4] dt-bindings: usb: Add Diodes Incorporated PI5USB30213A Type-C Controller Message-ID: <20240924072436.gya7hvmlpb7fk5ou@pengutronix.de> References: <20240923151417.1665431-1-michal.vokac@ysoft.com> <20240923151417.1665431-4-michal.vokac@ysoft.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240923151417.1665431-4-michal.vokac@ysoft.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-usb@vger.kernel.org On 24-09-23, Michal Vokáč wrote: > From: Petr Benes > > Diodes Incorporated PI5USB30213A Type-C Controller supports host, > device, and dual-role mode based on voltage levels detected on CC > pin. Supports dual differential channel, 2:1 USB 3.0 Mux/Demux, > USB Type-C specification 1.1. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Petr Benes > Signed-off-by: Michal Vokáč > --- > v3: > - Collected R-b tag from Krzysztof. > v2: > - Moved maintainers before description: block. > - Used full paths for references. > - Removed unneeded items form connector property. > - Fixed example. > > .../bindings/usb/diodes,pi5usb30213a.yaml | 88 +++++++++++++++++++ I suppose the driver is part of an other patchset? Regards, Marco > 1 file changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml > > diff --git a/Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml b/Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml > new file mode 100644 > index 000000000000..054a5409bd15 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/diodes,pi5usb30213a.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/diodes,pi5usb30213a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: PI5USB30213A Type-C port controller > + > +maintainers: > + - Petr Benes > + > +description: > + Diodes Incorporated PI5USB30213A Type-C Controller supports host, > + device, and dual-role mode based on voltage levels detected on CC > + pin. Dual differential channel, 2:1 USB 3.0 Mux/Demux, USB Type-C > + specification 1.1 compliant. > + > +properties: > + compatible: > + enum: > + - diodes,pi5usb30213a > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + connector: > + type: object > + $ref: /schemas/connector/usb-connector.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - connector > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + typec@d { > + compatible = "diodes,pi5usb30213a"; > + reg = <0xd>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_typec>; > + interrupts-extended = <&gpio1 5 IRQ_TYPE_LEVEL_LOW>; > + > + connector { > + compatible = "usb-c-connector"; > + label = "USB-C"; > + vbus-supply = <®_typec>; > + power-role = "source"; > + data-role = "dual"; > + typec-power-opmode = "default"; > + pd-disable; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + usb_con_hs: endpoint { > + remote-endpoint = <&typec_hs>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + usb_con_ss: endpoint { > + remote-endpoint = <&typec_ss>; > + }; > + }; > + }; > + }; > + }; > + }; > -- > 2.43.0 > > >